Slightly better HIP un-mitigation in 91X

[gpetruc]

Update era-based muon HIP unmitigation of #17807 to better match the 80X version #18218, which performs somewhat better (higher hit efficiency on good muons)

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @ebrondol, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18982/console Started: 2017/04/06 18:07

[cmsbuild]

+1
Tested at: 35f6322
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18245/18982/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18245/18982/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• results differ 1232 all_OldVSNew_TTbarPUwf50202p0 JR results differ 376 all_mini_OldVSNew_TTbarPUwf50202p0 JR results differ 106 all_mini_OldVSNew_RunSinglePh2016Bwf136p731 JR results differ 262 all_OldVSNew_RunSinglePh2016Bwf136p731 SUMMARY Reco comparison results: 1976 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1913203
• DQMHistoTests: Total failures: 20762
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1892267
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[slava77]

+1

for #18245 35f6322

• going back to a version originally presented in XPF in February https://indico.cern.ch/event/614937/ : keep HIP mitigation for InOut to improve track length, remove mitigation from OutIn hitCollectorForOutInMuonSeeds part [the latter apparently has rather small effect].
• jenkins tests pass and comparisons with baseline show small changes in 136.761 (2016B SinglePhoton PD) with changes more noticeable for muons as expected
• local test with 136.76 (2016E DoubleMuon PR, which has larger impact of the "HIP" effect) shows roughly expected behavior: there are 0.5% less muons with bad quality; InOut tracks are longer. CPU changes are negligible.

[the 4th bin is MAX_CONSECUTIVE_LOST_HITS]

the longer tracks are of a bit worse quality (small chi2 prob)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1