CTPPS: diamond miniAOD #18254

forthommel · 2017-04-07T10:21:08Z

This PR includes the diamond fitted tracks (introduced since #17817) within the CTPPSLocalTrackLite collection propagated up to the miniAOD format.
It alters the producer developed by @jan-kaspar and pushed to the 9_1_X through #17701.

…ks content

…s, diamond, ...)

cmsbuild · 2017-04-07T10:22:14Z

A new Pull Request was created by @forthommel (Laurent Forthomme) for master.

It involves the following packages:

RecoCTPPS/TotemRPLocal

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

slava77 · 2017-04-07T10:50:21Z

@cmsbuild please test

cmsbuild · 2017-04-07T10:50:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18993/console Started: 2017/04/07 12:51

slava77 · 2017-04-07T11:58:15Z

RecoCTPPS/TotemRPLocal/plugins/CTPPSLocalTrackLiteProducer.cc

+  // process tracks from diamond detectors
+  for ( const auto rpv : *inputDiamondTracks ) {
+    const unsigned int rpId = rpv.detId();
+    for ( const auto t : rpv ) {


auto const& to avoid copies

cmsbuild · 2017-04-07T12:03:28Z

-1

Tested at: f7e1aa9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18254/18993/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:40:37 2017-date Fri Apr 7 13:37:47 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:43:54 2017-date Fri Apr 7 13:37:48 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:49:29 2017-date Fri Apr 7 13:37:55 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:48:21 2017-date Fri Apr 7 13:38:00 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_MC.root --fileout file:RelVal_Raw_GRun2016_MC_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:52:40 2017-date Fri Apr 7 13:40:46 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:48:20 2017-date Fri Apr 7 13:42:07 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:52:11 2017-date Fri Apr 7 13:45:28 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:54:43 2017-date Fri Apr 7 13:48:50 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:56:20 2017-date Fri Apr 7 13:50:29 2017 s - exit: 20736
cmsDriver.py RelVal -s HLT:GRun2016,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun2016 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun2016_DATA.root --fileout file:RelVal_Raw_GRun2016_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 7 13:56:52 2017-date Fri Apr 7 13:52:13 2017 s - exit: 20736

cmsbuild · 2017-04-07T12:03:30Z

Comparison job queued.

cmsbuild · 2017-04-07T14:15:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18254/18993/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3249 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1917209
DQMHistoTests: Total failures: 30520
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1886516
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-04-09T21:23:43Z

addon test failures are related to this PR:

Unrunnable schedule
Module run order problem found: 
ctppsDiamondLocalTracks after ctppsDiamondRecHits [path reconstruction_step], ctppsDiamondRecHits after ctppsLocalTrackLiteProducer [path reconstruction_step], ctppsLocalTrackLiteProducer consumes ctppsDiamondLocalTracks
 Running in the threaded framework would lead to indeterminate results.
 Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18254/18993/addOnTests/hlt_data_GRun2016/

forthommel · 2017-04-10T16:59:15Z

Did not manage to reproduce this add-on test failure at f7e1aa9:
runTheMatrix.py -l limited yielded 16 16 15 13 7 1 1 1 tests passed, 1 0 0 0 0 0 0 0 failed (4.22 with Step0-DAS_ERROR Step1-NOTRUN Step2-NOTRUN Step3-NOTRUN Step4-NOTRUN)

cmsbuild · 2017-04-11T15:06:26Z

Pull request #18254 was updated. @perrotta, @civanch, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

forthommel · 2017-04-11T15:19:02Z

Thanks for your comments @slava77, @perrotta! The add-on issues should be fixed with this last commit.

slava77 · 2017-04-11T15:22:41Z

@cmsbuild please test

cmsbuild · 2017-04-11T15:23:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19107/console Started: 2017/04/11 17:25

cmsbuild · 2017-04-11T16:06:14Z

+1
Tested at: f79712b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18254/19107/summary.html

cmsbuild · 2017-04-11T16:06:18Z

Comparison job queued.

cmsbuild · 2017-04-11T18:37:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18254/19107/summary.html

Comparison Summary:

You potentially added 33 lines to the logs
Reco comparison results: 1630 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1921141
DQMHistoTests: Total failures: 53723
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1867245
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

perrotta · 2017-04-12T10:50:13Z

+1
Code updates look correct
No effect on standard workflows
The size increase on miniAOD has been computed with the test config included (ZeroBias data from Run2016H), and it amounts to ~27 bytes/evt

slava77 · 2017-04-12T11:30:40Z

On 4/12/17 3:50 AM, perrotta wrote: +1 Code updates look correct No effect on standard workflows The size increase on miniAOD has been computed with the test config included (ZeroBias data from Run2016H), and it amounts to ~27 bytes/evt

what is the name of the new branch?

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18254 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbnq1-d-iMWioAV8hHdfmHKdSJfabks5rvKxmgaJpZM4M2uKO>.

forthommel · 2017-04-12T11:43:16Z

Hi @slava77 There is no new branch introduced via this PR. The ctppsLocalTrackLiteProducer branch content is enlarged and now contains the diamond detectors' tracks

civanch · 2017-04-12T11:53:45Z

+1

cmsbuild · 2017-04-12T11:54:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

slava77 · 2017-04-12T12:10:09Z

On 4/12/17 4:43 AM, Laurent Forthomme wrote: Hi @slava77 <https://github.com/slava77> There is no new branch introduced via this PR. The |ctppsLocalTrackLiteProducer| branch content is enlarged and now contains the diamond detectors' tracks

Thanks. This makes it easier then. I was checking to know if I need to add a new branch to plot in the reco validation (validateJR outputs in the cms-bot/jenkins tests). I guess then that comment from Andrea that there is no effect on standard workflows means that the code actually runs in the standard workflows and the samples tested do not include diamond data.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18254 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbjo0H3yi1ANkvGwri6fpzvKt-BQqks5rvLjVgaJpZM4M2uKO>.

davidlange6 · 2017-04-13T09:26:52Z

+1

forthommel added 7 commits April 6, 2017 13:01

Added the diamond local tracks information into the miniAOD lite trac…

371c0f5

…ks content

Added an extra test for strips + diamond unpacking-reco up to miniAOD

df5582c

Test cleanup

52e2925

Storing one single collection, regardless the input collection (strip…

54fc631

…s, diamond, ...)

Moved 'consumes' statements inside the constructor definition

7be2bfb

Cleanup of diamond test

22b3f95

Test is using an actual RAW file with diamond inserted and part of GR

f7e1aa9

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 7, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 7, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2017

slava77 reviewed Apr 7, 2017

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Apr 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 7, 2017

Auto range loops now using references

9126459

cmsbuild removed the comparison-available label Apr 10, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 11, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 11, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 11, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 12, 2017

cmsbuild added fastsim-approved fully-signed and removed fastsim-pending pending-signatures labels Apr 12, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 13, 2017

cmsbuild merged commit 18fc178 into cms-sw:master Apr 13, 2017

forthommel deleted the ctpps-diamond-miniaod_91X branch July 17, 2017 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS: diamond miniAOD #18254

CTPPS: diamond miniAOD #18254

forthommel commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

slava77 commented Apr 7, 2017

cmsbuild commented Apr 7, 2017 •

edited

slava77 Apr 7, 2017

cmsbuild commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

slava77 commented Apr 9, 2017

forthommel commented Apr 10, 2017

cmsbuild commented Apr 11, 2017

forthommel commented Apr 11, 2017

slava77 commented Apr 11, 2017

cmsbuild commented Apr 11, 2017 •

edited

cmsbuild commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

perrotta commented Apr 12, 2017

slava77 commented Apr 12, 2017 via email

forthommel commented Apr 12, 2017

civanch commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

slava77 commented Apr 12, 2017 via email

davidlange6 commented Apr 13, 2017

CTPPS: diamond miniAOD #18254

CTPPS: diamond miniAOD #18254

Conversation

forthommel commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

slava77 commented Apr 7, 2017

cmsbuild commented Apr 7, 2017 • edited

slava77 Apr 7, 2017

Choose a reason for hiding this comment

cmsbuild commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

cmsbuild commented Apr 7, 2017

slava77 commented Apr 9, 2017

forthommel commented Apr 10, 2017

cmsbuild commented Apr 11, 2017

forthommel commented Apr 11, 2017

slava77 commented Apr 11, 2017

cmsbuild commented Apr 11, 2017 • edited

cmsbuild commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

cmsbuild commented Apr 11, 2017

perrotta commented Apr 12, 2017

slava77 commented Apr 12, 2017 via email

forthommel commented Apr 12, 2017

civanch commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

slava77 commented Apr 12, 2017 via email

davidlange6 commented Apr 13, 2017

cmsbuild commented Apr 7, 2017 •

edited

cmsbuild commented Apr 11, 2017 •

edited