Inclusion of muon timing plots in the DQMOffline/Muon package #18267
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| #ifndef MuonTiming_H | ||
| #define MuonTiming_H | ||
|
|
||
| /** \class MuRecoAnalyzer | ||
| * | ||
| * DQM monitoring source for muon reco track | ||
| * | ||
| * \author G. Mila - INFN Torino | ||
| */ | ||
|
|
||
| #include <memory> | ||
| #include <fstream> | ||
| #include "FWCore/Framework/interface/Frameworkfwd.h" | ||
| #include "FWCore/Utilities/interface/InputTag.h" | ||
| #include "FWCore/ParameterSet/interface/ParameterSet.h" | ||
| #include "FWCore/Framework/interface/Event.h" | ||
| #include "FWCore/Framework/interface/MakerMacros.h" | ||
| #include "FWCore/ServiceRegistry/interface/Service.h" | ||
|
|
||
| #include "DQMServices/Core/interface/DQMStore.h" | ||
| #include "DQMServices/Core/interface/MonitorElement.h" | ||
| #include "DQMServices/Core/interface/DQMEDAnalyzer.h" | ||
|
|
||
| #include "RecoMuon/TrackingTools/interface/MuonServiceProxy.h" | ||
|
|
||
| #include "DataFormats/MuonReco/interface/Muon.h" | ||
| #include "DataFormats/MuonReco/interface/MuonFwd.h" | ||
|
|
||
| class MuonTiming : public DQMEDAnalyzer { | ||
| public: | ||
|
|
||
| /// Constructor | ||
| MuonTiming(const edm::ParameterSet&); | ||
|
|
||
| /// Destructor | ||
| virtual ~MuonTiming(); | ||
|
|
||
| /// Inizialize parameters for histo binning | ||
| void analyze(const edm::Event&, const edm::EventSetup&) override; | ||
| void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override; | ||
|
|
||
| private: | ||
| // ----------member data --------------------------- | ||
| MuonServiceProxy *theService; | ||
| edm::ParameterSet parameters; | ||
|
|
||
| edm::EDGetTokenT<edm::View<reco::Muon> > theMuonCollectionLabel_; | ||
| // Switch for verbosity | ||
| std::string metname; | ||
|
|
||
|
|
||
| //histo binning parameters | ||
| int tnbins; | ||
|
There was a problem hiding this comment. please follow a naming convention for variables that make up a class. Eg, in CMS its often an '_' at the end of the variable. There was a problem hiding this comment. I have added a '_' at the end of all of them. |
||
| int tnbinsrpc; | ||
| int terrnbins; | ||
| int terrnbinsrpc; | ||
| int ndofnbins; | ||
| int ptnbins; | ||
| int etanbins; | ||
| double tmax, tmin; | ||
| double tmaxrpc, tminrpc; | ||
| double terrmax, terrmin; | ||
| double terrmaxrpc, terrminrpc; | ||
| double ndofmax, ndofmin; | ||
| double ptmax, ptmin; | ||
| double etamax, etamin; | ||
| double etaBarrelMin, etaBarrelMax, etaEndcapMin, etaEndcapMax, etaOverlapMin, etaOverlapMax; | ||
|
|
||
| std::string theFolder; | ||
| std::vector<std::string> EtaName, ObjectName; | ||
| enum eta {overlap, barrel, endcap}; | ||
| enum object {sta, glb}; | ||
| //the histos | ||
| std::vector<std::vector<MonitorElement*>> timeNDof; | ||
|
There was a problem hiding this comment. as the sizes of these are known (and hardwired), please use std::array<std::array<MonitorElement*,1>,3> to avoid both the extra memory of the vectors and the need to first declare a vector and then push_back There was a problem hiding this comment. Hi, yes. That's way smarter. Sorry for not having thought about it in the first place. It's now implemented. |
||
| std::vector<std::vector<MonitorElement*>> timeAtIpInOut; | ||
| std::vector<std::vector<MonitorElement*>> timeAtIpInOutRPC; | ||
| std::vector<std::vector<MonitorElement*>> timeAtIpInOutErr; | ||
| std::vector<std::vector<MonitorElement*>> timeAtIpInOutErrRPC; | ||
| std::vector<MonitorElement*> etaptVeto; | ||
|
There was a problem hiding this comment. Yes, updated as well. |
||
| std::vector<MonitorElement*> etaVeto; | ||
| std::vector<MonitorElement*> ptVeto; | ||
| std::vector<MonitorElement*> yields; | ||
|
|
||
| }; | ||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import FWCore.ParameterSet.Config as cms | ||
|
|
||
| from RecoMuon.TrackingTools.MuonServiceProxy_cff import * | ||
|
|
||
| muonTiming = cms.EDAnalyzer("MuonTiming", | ||
| MuonServiceProxy, | ||
| MuonCollection = cms.InputTag("muons"), | ||
| # histograms parameters | ||
| tnbins = cms.int32(40), | ||
| tnbinsrpc = cms.int32(20), | ||
| terrnbins = cms.int32(20), | ||
| terrnbinsrpc = cms.int32(20), | ||
| ndofnbins = cms.int32(40), | ||
| ptnbins = cms.int32(20), | ||
| etanbins = cms.int32(20), | ||
| tmax = cms.double(300), | ||
| tmaxrpc = cms.double(30), | ||
| terrmax = cms.double(10), | ||
| terrmaxrpc = cms.double(10), | ||
| ndofmax = cms.double(40), | ||
| ptmax = cms.double(200), | ||
| etamax = cms.double(2.4), | ||
| tmin = cms.double(-300), | ||
| tminrpc = cms.double(-30), | ||
| terrmin = cms.double(0), | ||
| terrminrpc = cms.double(0), | ||
| ndofmin = cms.double(0), | ||
| ptmin = cms.double(0), | ||
| etamin = cms.double(-2.4), | ||
| etaBarrelMin = cms.double(0), | ||
| etaBarrelMax = cms.double(1.1), | ||
| etaOverlapMin = cms.double(0.9), | ||
| etaOverlapMax = cms.double(1.1), | ||
| etaEndcapMin = cms.double(0.9), | ||
| etaEndcapMax = cms.double(2.4), | ||
| folder = cms.string("Muons/MuonTiming") | ||
| ) | ||
|
|
||
| muonTiming_miniAOD = cms.EDAnalyzer("MuonTiming", | ||
| MuonServiceProxy, | ||
| MuonCollection = cms.InputTag("slimmedMuons"), | ||
| # histograms parameters | ||
| tnbins = cms.int32(40), | ||
| tnbinsrpc = cms.int32(20), | ||
| terrnbins = cms.int32(20), | ||
| terrnbinsrpc = cms.int32(20), | ||
| ndofnbins = cms.int32(40), | ||
| ptnbins = cms.int32(20), | ||
| etanbins = cms.int32(20), | ||
| tmax = cms.double(300), | ||
| tmaxrpc = cms.double(30), | ||
| terrmax = cms.double(10), | ||
| terrmaxrpc = cms.double(10), | ||
| ndofmax = cms.double(40), | ||
| ptmax = cms.double(200), | ||
| etamax = cms.double(2.4), | ||
| tmin = cms.double(-300), | ||
| tminrpc = cms.double(-30), | ||
| terrmin = cms.double(0), | ||
| terrminrpc = cms.double(0), | ||
| ndofmin = cms.double(0), | ||
| ptmin = cms.double(0), | ||
| etamin = cms.double(-2.4), | ||
| etaBarrelMin = cms.double(0), | ||
| etaBarrelMax = cms.double(1.1), | ||
| etaOverlapMin = cms.double(0.9), | ||
| etaOverlapMax = cms.double(1.1), | ||
| etaEndcapMin = cms.double(0.9), | ||
| etaEndcapMax = cms.double(2.4), | ||
| folder = cms.string("Muons_miniAOD/MuonTiming") | ||
| ) | ||
|
|
||
|
|
||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @parbol - sorry I missed this before - the include guard should have the package name to ensure no conflicts - eg
ifndef DQMOffline_Muon_MuonTiming_H
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks again. This has been adapted.