New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTupdates_for_910pre3_L1O2OTags_HCAL2018Geo_PCL_TkAl_AlignableThresholds #18269
GTupdates_for_910pre3_L1O2OTags_HCAL2018Geo_PCL_TkAl_AlignableThresholds #18269
Conversation
A new Pull Request was created by @arunhep (Arun Kumar) for master. It involves the following packages: Configuration/AlCa @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
@arunhep @franzoni this will not work. I am expecting failure of wf 1001.0, due to a duplication of ESSource for the
You are welcome to cherry-pick this commit : mmusich@d87f994 |
…lignPCLThresholdsRcd
@cmsbuild please abort |
@arunhep thanks! |
@cmsbuild please abort |
-1 Tested at: ead3bfe You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log136.731 step3 runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Fri Apr 7 20:04:31 2017-date Fri Apr 7 20:01:33 2017 s - exit: 16640 |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: fe5238d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Sat Apr 8 00:09:12 2017-date Sat Apr 8 00:05:43 2017 s - exit: 16640 |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@arunhep The configuration of the Also the DIGI collection validation plots, seem to point to a genuine change in the Strip DIGIs. Now, at contrast with the description you provided, for the PhaseI 2017 realistic scenario Global Tag there is at least one change involving the digitization step (namely via |
Thanks @mmusich,
How far would the irreproducibility triggered by a change in digi conditions propagate (I have a limited understanding of the pseudo-random number generation ) ? Your hypothesis is supported by small perturbations to the ECAL digi occupancy , though no analogous changes are found in the HcalDigiTask. |
From HCAL side with the update of the HCALParameters_Geometry_91YV3 tag |
Nice!
Not being a digitization expert I cannot judge and defer to those more savvy than I am in this respect. process.GlobalTag = GlobalTag(process.GlobalTag, '91X_upgrade2017_realistic_v3', '')
process.GlobalTag.toGet.extend(
cms.VPSet(cms.PSet(connect= cms.string("frontier://FrontierProd/CMS_CONDITIONS"),
record = cms.string("SiPixelLorentzAngleSimRcd"),
tag = cms.string("SiPixelLorentzAngleSim_phase1_mc_v1")
)
)
) I am able to restore a bitwise identity with the previous spectra. |
hello @mmusich We've also found that the DIGI step of the workflow has a single instance of the RandomNumberGeneratorService , which supports your original conjecture.
Thanks for the help, this PR is good to go for AlCa. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
Summary of changes in Global Tags
RunI data
RunI HLT processing : 91X_dataRun2_HLT_frozen_v3 as 91X_dataRun2_HLT_frozen_v1 with the following changes:
RunI Offline processing : 91X_dataRun2_v3 as 91X_dataRun2_v1 with the following changes:
RunII data
RunII HLTHI processing : 91X_dataRun2_HLTHI_frozen_v3 as 91X_dataRun2_HLTHI_frozen_v1 with the following changes:
RunII HLT processing : 91X_dataRun2_HLT_frozen_v3 as 91X_dataRun2_HLT_frozen_v1 with the following changes:
RunII HLT relval processing : 91X_dataRun2_HLT_relval_v3 as 91X_dataRun2_HLT_relval_v1 with the following changes:
RunII Offline processing : 91X_dataRun2_v3 as 91X_dataRun2_v1 with the following changes:
RunII Offline relval processing : 91X_dataRun2_relval_v3 as 91X_dataRun2_relval_v1 with the following changes:
RunII Prompt processing : 91X_dataRun2_PromptLike_v3 as 91X_dataRun2_PromptLike_v1 with the following changes:
Upgrade
PhaseI 2017 cosmics peak scenario : 91X_upgrade2017cosmics_realistic_peak_v3 as 91X_upgrade2017cosmics_realistic_peak_v2 with the following changes:
PhaseI 2017 cosmics scenario : 91X_upgrade2017cosmics_realistic_deco_v3 as 91X_upgrade2017cosmics_realistic_deco_v2 with the following changes:
PhaseI 2017 design scenario : 91X_upgrade2017_design_IdealBS_v3 as 91X_upgrade2017_design_IdealBS_v2 with the following changes:
PhaseI 2017 realistic scenario : 91X_upgrade2017_realistic_v3 as 91X_upgrade2017_realistic_v2 with the following changes:
PhaseI 2018 cosmics scenario : 91X_upgrade2018cosmics_realistic_deco_v3 as 91X_upgrade2018cosmics_realistic_deco_v2 with the following changes:
PhaseI 2018 design scenario : 91X_upgrade2018_design_IdealBS_v3 as 91X_upgrade2018_design_IdealBS_v2 with the following changes:
PhaseI 2018 realistic scenario : 91X_upgrade2018_realistic_v3 as 91X_upgrade2018_realistic_v2 with the following changes: