Update of L1T DQMOffline code and Validation

[joaopela]

Including L1T code into Validation package
Including latest development of L1T DQMOffline code

[cmsbuild]

A new Pull Request was created by @joaopela for CMSSW_7_0_X.

Update of L1T DQMOffline code and Validation

It involves the following packages:

DQM/L1TMonitor
DQMOffline/L1Trigger
Validation/Configuration
Validation/L1T

The following packages do not have a category, yet:

Validation/L1T

@civanch, @thspeer, @deguio, @danduggan, @mdhildreth, @ktf, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @eliasron, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[cmsbuild]

Pull request #1827 was updated. @civanch, @thspeer, @deguio, @danduggan, @mdhildreth, @ktf, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @eliasron, @mulhearn can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1827/1779/summary.html

[thspeer]

working @thspeer

[thspeer]

+1
Tested 6c8bdcb in CMSSW_7_0_X_2013-12-16-0200_1827
No difference in reco as expected, based on RelMon and reco script

[deguio]

ciao @joaopela
I have a failure when running
python whiteRabbit.py -j1 -n3

here the error message:
%MSG
----- Begin Fatal Exception 16-Dec-2013 17:07:17 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'validation_step'
[2] Calling event method for module L1Validator/'L1Validator'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vectorl1extra::L1EmParticle
Looking for module label: l1extraParticles
Looking for productInstanceName: Isolated

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

could you look into it please?
thank you,
F.

[joaopela]

ciao @deguio

Found bug in whiteRabbit.py (missing L1Reco in cmsDriver command to obtain correct l1extra collections normally present at AOD) sent details to you via email. Now waiting for re-testing. 👯

[cmsbuild]

Pull request #1827 was updated. @civanch, @thspeer, @deguio, @danduggan, @mdhildreth, @ktf, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @eliasron, @mulhearn can you please check and sign again.

[joaopela]

OK, I think I did the rebase correctly. Can someone check and came back to me?

[deguio]

+1
I did test it already. everything seems to work.
after your last commit I didn't see need of a rebase.

[deguio]

ciao @ktf
this one affects only DQM packages and should target pre11
I hope that the other signatures (I don't know why they are required) will come in time.

thanks,
F.

[ktf]

Please remove these. CVS keywords only make a mess.

[deguio]

@joaopela @ktf
then, since you have to touch it again, I add something.
please remove also the file gitWorkflow.txt
and all the commented lines containing getByLabel

thanks!

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1827/1834/summary.html

[joaopela]

@deguio the file gitWorkflow.txt is inside the docs directory and will contain soon the sequences of commands necessary to setup, test and deploy the L1T DQM. I do not see why I need to remove it.

[joaopela]

Ups, closed this accidentally.

[joaopela]

@ktf and @deguio Pushed code with comments fixed.

[cmsbuild]

Pull request #1827 was updated. @civanch, @thspeer, @deguio, @danduggan, @mdhildreth, @ktf, @cmsbuild, @anton-a, @nclopezo, @rovere, @giamman, @slava77, @eliasron, @mulhearn can you please check and sign again.

[deguio]

+1
again: this should be included in pre11. it contains a new validation package for L1T

[ktf]

Package is now approved.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1827/1853/summary.html

[thspeer]

+1
Tested c759490 in CMSSW_7_0_X_2013-12-19-0200_1827
No difference in reco as expected, based on RelMon and reco script

[mulhearn]

+1

[ktf]

sim comes only from Validation/Configuration, which simply enables the sequence. Bypassing @mdhildreth @civanch, please shout if not ok.