Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2019 Extended Scenario #18289

Merged
merged 1 commit into from Apr 12, 2017
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 10, 2017

  • Make sure 2019 scenario is usable
  • Synchronize to 2018 changes in infrastructure
  • Add PixelNose

@ianna
Copy link
Contributor Author

ianna commented Apr 10, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19054/console Started: 2017/04/10 16:54

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

@ianna what is the 2019 scenario supposed to represent right now?

At some point we need to make a post-LS2 geometry (#16680): 2018 (=2017 + HE upgrade) + HB upgrade + GE1/1. Then there should be a corresponding workflow. I plan to do this at some point; your help with the geometry could be useful.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18289/19054/summary.html

Comparison Summary:

  • You potentially added 300 lines to the logs
  • Reco comparison results: 3257 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1917243
  • DQMHistoTests: Total failures: 29886
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1887184
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Apr 11, 2017

@kpedro88 - 2019 was there to accommodate full GEM. Eventually, it should evolve in 2020, I think. One option is to remove it, but it is referenced in many places and I do not want anything to be broken in the upcoming release. It's quicker to fix it.

@ianna
Copy link
Contributor Author

ianna commented Apr 11, 2017

+1

@kpedro88
Copy link
Contributor

@ianna okay, thanks for the clarification

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0502f5 into cms-sw:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants