Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed function static to atomic in RunRangeDependentPedeLabeler #18297

Merged
merged 1 commit into from Apr 11, 2017
Merged

Changed function static to atomic in RunRangeDependentPedeLabeler #18297

merged 1 commit into from Apr 11, 2017

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 10, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19071/console Started: 2017/04/10 21:42

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

+1
Tested at: 04b1918
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18297/19071/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
99423ef
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18297/19071/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18297/19071/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18297/19071/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3236 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1917209
  • DQMHistoTests: Total failures: 45230
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1871806
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@franzoni
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fc0c1e2 into cms-sw:master Apr 11, 2017
@Dr15Jones Dr15Jones deleted the safeStaticInRunRangeDependentPedeLabeler branch April 11, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @franzoni @davidlange6