By default digitize single partition ME0 geometry with custom parameters #18302
Conversation
|
A new Pull Request was created by @nickmccoll (Nick McColl) for master. It involves the following packages: SimMuon/GEMDigitizer @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -183,11 +184,20 @@ void ME0ReDigiProducer::beginRun(const edm::Run&, const edm::EventSetup& eventSe | |||
| eventSetup.get<MuonGeometryRecord>().get(hGeom); | |||
| geometry= &*hGeom; | |||
|
|
|||
| const auto& chambers = geometry->chambers(); | |||
| if(!chambers.size()) | |||
There was a problem hiding this comment.
Probably better to use:
if(chambers.empty())
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #18302 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
+1 |
PR #18113 Updated the digitizer to use either the built-in geometry or the custom one defined in the parameter set. For single partition geometries, which will not be used in the Muon TDR, this resulted in a single partition digitization. In order to allow for better default behavior in geometries such as D4 the default is to now use the custom geometry whenever there is a single partition geometry.
The "useBuiltInGeo" parameter wasn't useful for geometries other than single partition ones. It would return an error if you tried to use it on a multi-partition one. Instead it was replaced with "useCusGeoFor1PartGeo" which is only used on single partition geometries. No change in the reconstruction for the default, D12 geometry.
D4 geometry (1 partition) before this PR:
hitMap_D4_beforePR.pdf
D4 geometry (1 partition) after this PR:
hitMap_D4_afterPR.pdf
D12 geometry (8 partition) before this PR:
hitMap_D12_beforePR.pdf
D12 geometry (8 partition) after this PR:
hitMap_D12_afterPR.pdf
There is a displacement in local (chamber) coordinates between D4 and D12. This is due tot he placement of the eta partitions within the D4 geo. It doesn't affect segment reconstruction as it is simply a uniform displacement in Y.