Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 1 training for BoostedDoubleSV tagger for AK8 jets #18318

Conversation

ferencek
Copy link
Contributor

New Phase 1 training for BoostedDoubleSV tagger for AK8 jets.

Request to add new training to externals is here cms-sw/cmsdist#2951

@cvernier

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

RecoBTag/SecondaryVertex

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ferencek
Copy link
Contributor Author

Please hold off any tests until the external training file is integrated into 91X IBs.

@iahmad-khan
Copy link
Contributor

please test with cms-sw/cmsdist#2953

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#2953
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19125/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18318/19125/summary.html

Comparison Summary:

  • You potentially added 23 lines to the logs
  • Reco comparison results: 1633 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921491
  • DQMHistoTests: Total failures: 36000
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1885318
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@@ -8,3 +8,6 @@
useGBRForest = cms.bool(True),
useAdaBoost = cms.bool(False)
)

from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
phase1Pixel.toModify(candidateBoostedDoubleSecondaryVertexAK8Computer, weightFile = cms.FileInPath('RecoBTag/SecondaryVertex/data/BoostedDoubleSV_AK8_BDT_PhaseI_v1.weights.xml.gz'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the plan to have this in GT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment there is no plan. From the past experience it is much easier, more convenient, and faster to handle training files as externals. Perhaps things are better now with GTs but I doubt we can get a new GT created on the same times scale on which externals can be integrated in the IBs.

@slava77
Copy link
Contributor

slava77 commented Apr 17, 2017

@ferencek
what is the plan to add these taggers to DQM?

@slava77
Copy link
Contributor

slava77 commented Apr 17, 2017

+1

for #18318 7f2561c

  • changes are as described
  • jenkins tests pass and comparisons with baseline show no differences (the double-boosted tagger is not monitored)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Apr 17, 2017

@davidlange6
just FYI, the external needed for this PR was merged to cms-sw:IB/CMSSW_9_1_X/gcc530 on Apr 13

@davidlange6 davidlange6 merged commit e59268f into cms-sw:master Apr 18, 2017
@ferencek ferencek deleted the BoostedDoubleSVTaggerPhaseIV1-PR_from-CMSSW_9_1_0_pre2 branch April 18, 2017 14:02
@ferencek
Copy link
Contributor Author

@slava77, at the moment DQM is implemented only for taggers run in the standard reco. And in the standard reco we run b tagging only on ak4 jets. At some point in the future this tagger could be included in DQM but for now there are no concrete plans that I am aware of.

@slava77
Copy link
Contributor

slava77 commented Apr 18, 2017 via email

@ferencek
Copy link
Contributor Author

Thanks for pointing out the MiniAOD-specific DQM sequence. To be honest, it completely slipped my mind. We will then have to add this to the development plans.
@mverzett @JyothsnaKomaragiri @imarches @cvernier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants