New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 1 training for BoostedDoubleSV tagger for AK8 jets #18318
Phase 1 training for BoostedDoubleSV tagger for AK8 jets #18318
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for master. It involves the following packages: RecoBTag/SecondaryVertex @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Please hold off any tests until the external training file is integrated into 91X IBs. |
please test with cms-sw/cmsdist#2953 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -8,3 +8,6 @@ | |||
useGBRForest = cms.bool(True), | |||
useAdaBoost = cms.bool(False) | |||
) | |||
|
|||
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel | |||
phase1Pixel.toModify(candidateBoostedDoubleSecondaryVertexAK8Computer, weightFile = cms.FileInPath('RecoBTag/SecondaryVertex/data/BoostedDoubleSV_AK8_BDT_PhaseI_v1.weights.xml.gz')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the plan to have this in GT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment there is no plan. From the past experience it is much easier, more convenient, and faster to handle training files as externals. Perhaps things are better now with GTs but I doubt we can get a new GT created on the same times scale on which externals can be integrated in the IBs.
@ferencek |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
@davidlange6 |
@slava77, at the moment DQM is implemented only for taggers run in the standard reco. And in the standard reco we run b tagging only on ak4 jets. At some point in the future this tagger could be included in DQM but for now there are no concrete plans that I am aware of. |
On 4/18/17 7:04 AM, Dinko Ferencek wrote:
@slava77 <https://github.com/slava77>, at the moment DQM is implemented
only for taggers run in the standard reco. And in the standard reco we
run b tagging only on ak4 jets. At some point in the future this tagger
could be included in DQM but for now there are no concrete plans that I
am aware of.
double-boosted is a part of standard processing (miniAOD step).
So, it should be monitored in the corresponding miniAOD DQM/validation
sequences.
… —
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18318 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbhzMQIjTwaxf2viPyd2j38hXrNXIks5rxML3gaJpZM4M6nOo>.
|
Thanks for pointing out the MiniAOD-specific DQM sequence. To be honest, it completely slipped my mind. We will then have to add this to the development plans. |
New Phase 1 training for BoostedDoubleSV tagger for AK8 jets.
Request to add new training to externals is here cms-sw/cmsdist#2951
@cvernier