Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ss threadsafe ecal digi to raw #18322

Merged
merged 21 commits into from Aug 8, 2017
Merged

Ss threadsafe ecal digi to raw #18322

merged 21 commits into from Aug 8, 2017

Conversation

sabasehrish
Copy link
Contributor

No description provided.

@sabasehrish
making EcalDigiToRaw global
5a8361b
@sabasehrish
changed return type for startEvent, and removed the unnecessary data …
c52cf55 
…members from the TowerBlockFormatter
@sabasehrish
making EcalDigiToRaw global
815c9f6
@sabasehrish
changed return type for startEvent, and removed the unnecessary data …
d98e4d7 
…members from the TowerBlockFormatter
@sabasehrish
Merge branch 'ss_threadsafe_EcalDigiToRaw' of https://github.com/saba…
4dece5f 
…sehrish/cmssw into ss_threadsafe_EcalDigiToRaw
@sabasehrish
removed commented out pointer data member
13c591d
@sabasehrish
removed commented out delete, etc
43c5fe1
@sabasehrish
minor Clean up
3d7e339
@sabasehrish
changed stream to global, and added const to produce
854ddbe
@sabasehrish
removed unused data members, they were replaced by local data
73836dd
@sabasehrish
made use of const wherever possible
b317b09
@sabasehrish
minor comments
b33a924
@sabasehrish
Changed the input to CleanUp to be reference types instead of pointers
7b9f13d
@sabasehrish
Used make_unique
5482b29
@sabasehrish
made use of LogInfo
7bd56c5
@sabasehrish
removed destructors
66bb199
@sabasehrish
renamed the localmaporder struct to FEDMapOrder, fixed formatting and…
c40305b 
… moved it inside the class
@sabasehrish
minor cleanup
ac30299
@sabasehrish
made StartEvent inline, and minor cleanup
14a3f3e
@sabasehrish
made StartEvent inline
f6a8d99
@sabasehrish
removed data memeber AllTPsamples, it was set to false in the constru…
ddd1936 
…ctor
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 12, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017 •
edited by smuzaffar

A new Pull Request was created by @sabasehrish for master.

It involves the following packages:

EventFilter/EcalDigiToRaw

@mommsen, @cmsbuild, @emeschi, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@sabasehrish
Copy link
Contributor Author

@Dr15Jones

@Dr15Jones
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18322/19136/summary.html

Comparison Summary:

  • You potentially added 145 lines to the logs
  • Reco comparison results: 202 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921627
  • DQMHistoTests: Total failures: 30607
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1890846
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@smuzaffar smuzaffar modified the milestones: CMSSW_9_2_X, CMSSW_9_1_X May 4, 2017
@smuzaffar smuzaffar modified the milestones: CMSSW_9_3_X, CMSSW_9_2_X Jun 26, 2017
@Dr15Jones
Copy link
Contributor

ping

@mommsen
Copy link
Contributor

mommsen commented Aug 3, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor

@davidlange6

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c925d3e into cms-sw:master Aug 8, 2017
@dan131riley dan131riley mentioned this pull request Aug 10, 2017
Closed
@davidlange6 davidlange6 mentioned this pull request Aug 10, 2017
Merged
@slava77
Copy link
Contributor

slava77 commented Nov 7, 2017

@sabasehrish @mommsen @argiro
this PR was reverted on Aug 10 with #20119 to solve problems reported in #20116
is there a plan to make updates and reintroduce changes from this PR?

@cmsbuild cmsbuild modified the milestones: CMSSW_9_3_X, CMSSW_10_0_X Nov 7, 2017
@Dr15Jones
Copy link
Contributor

The original implementer of the pull request no longer is working for CMS.

@smuzaffar smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_9_3_X Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-pending comparison-available daq-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sabasehrish @cmsbuild @Dr15Jones @mommsen @davidlange6 @slava77 @smuzaffar