Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the use of a static from DQMHistPlotter #18338

Merged

Conversation

Dr15Jones
Copy link
Contributor

Replaced the use of a static by extending the one member function
it was used with to include that value by argument.

Replaced the use of a static by extending the one member function
it was used with to include that value by argument.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Validation/RecoTau

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19151/console Started: 2017/04/12 18:50

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18338/19151/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921661
  • DQMHistoTests: Total failures: 15164
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1906324
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Dr15Jones
Copy link
Contributor Author

ping

@davidlange6 davidlange6 merged commit 82ccb5a into cms-sw:master Apr 18, 2017
@Dr15Jones Dr15Jones deleted the removedStaticFromTauDQMHistPlotter branch May 4, 2017 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants