Lock access to lumi::service::DBService

[Dr15Jones]

Use a guard class to serialize access to the underlying coral
implementation of lumi::service::DBService

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoLuminosity/LumiProducer

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19156/console Started: 2017/04/12 21:48

[cmsbuild]

+1
Tested at: 04203e5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19156/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
919db20
cf6bf1f
c5bffcb
a05cf7f
a0502f5
44bc494
ce616fe
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19156/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19156/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19156/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 505 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1921491
• DQMHistoTests: Total failures: 15329
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1905989
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[davidlange6]

Hi @Dr15Jones @slava77 - this code is obsolete, no?

[Dr15Jones]

@davidlange6 since it was in the repository and modules call it, I made the necessary changes.

[slava77]

On 4/13/17 8:14 AM, David Lange wrote: Hi @Dr15Jones <https://github.com/Dr15Jones> @slava77 <https://github.com/slava77> - this code is obsolete, no?

it still runs it may be worth to remove it all from standard processing sequences.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18342 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbvcSyf6m4sMmudb_AHBlMt48I7cAks5rvju7gaJpZM4M74pT>.

[slava77]

@cmsbuild please test

to get cleaner comparisons

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19187/console Started: 2017/04/14 20:55

[cmsbuild]

+1
Tested at: 04203e5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19187/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18342/19187/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1643 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1818576
• DQMHistoTests: Total failures: 24696
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1793707
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[slava77]

+1

for #18342 04203e5

• technical changes, as described
• jenkins tests pass and comparisons with baseline show no relevant differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1
but yes it seems like this is not a functionality likely to be restored...