Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subjet b tagging information #18355

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2017

Replace unused subjet b tagging information (pfCombinedSecondaryVertexV2BJetTags) with the new DeepCSV information.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @imarches for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 13, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19171/console Started: 2017/04/13 19:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18355/19171/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1619 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826686
  • DQMHistoTests: Total failures: 21143
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1805380
  • DQMHistoTests: Total skipped: 163
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 15, 2017

+1

for #18355 9914aca

  • updated AK8PFPuppiSoftDropSubjets as described
  • jenkins tests pass and comparisons show no relevant differences [looks like the variables are not monitored]

@davidlange6 davidlange6 merged commit 5b6b654 into cms-sw:master Apr 15, 2017
@ferencek ferencek deleted the ImprovedSubjetBTaggingInfo_from-CMSSW_9_1_0_pre2 branch May 5, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants