Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS conditions database layout #18359

Merged
merged 6 commits into from May 10, 2017
Merged

CTPPS conditions database layout #18359

merged 6 commits into from May 10, 2017

Conversation

malbouis
Copy link
Contributor

code to account for CTPPS Conditions Database objects in CondCore/Utilities and CondCore/CTPPSPlugins

CalibForward package that contains analyzers to write sqlite file and retrieve conditions DB objects.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2017

A new Pull Request was created by @malbouis for master.

It involves the following packages:

CalibForward/CTPPSPixelCalibration
CondCore/CTPPSPlugins
CondCore/Utilities

The following packages do not have a category, yet:

CalibForward/CTPPSPixelCalibration
CondCore/CTPPSPlugins
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py to assign category

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Apr 13, 2017

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@mmusich,@cerminar,@arunhep,@franzoni,@ghellwig you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Apr 13, 2017

[following up after a private email from @fabferro ]
by just name association, it looks like CalibForward/CTPPSPixelCalibration belongs to alca.
So, I added a signature.
I'm expecting that the new packages (CalibForward/CTPPSPixelCalibration CondCore/CTPPSPlugins) are assigned to a relevant category after review by corresponding area reviewers and
a PR for https://github.com/cms-sw/cms-bot/blob/master/categories.py is then made to assign the category

@arunhep
Copy link
Contributor

arunhep commented Apr 25, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19373/console Started: 2017/04/25 14:24

@cmsbuild
Copy link
Contributor

-1

Tested at: 4241bd1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18359/19373/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented Apr 25, 2017

@cmsbuild please test

Caught a CMSSW exception when running connection recovery.
hopefully this is transient.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Pull request #18359 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Pull request #18359 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19612/console Started: 2017/05/05 21:31

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18359/19612/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1693 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 26795
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1804075
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 9, 2017

+1

@franzoni
Copy link

franzoni commented May 9, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants