Run2-alca78 Update the cff files for HCAL PhiSymmetry ALCARECO #18367
Conversation
|
@cmsbuild Please test |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalAlCaRecoProducers @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@franzoni Could you approve this? |
| processQIE11 = cms.bool(False), | ||
| setNegativeFlagsQIE8 = cms.bool(False), | ||
| setNegativeFlagsQIE11 = cms.bool(False), | ||
| setNoiseFlagsQIE8 = cms.bool(True), |
There was a problem hiding this comment.
Is this default value as True intended? Could you please briefly explain?
There was a problem hiding this comment.
This is the prescribed way of getting NZS reconstruction for HCAL.
There was a problem hiding this comment.
This came after a disussion between Igor (who has rewritten the reconstruction code) and Olga/myself. We only would permit negative values of ADC channels but allow noise rejection
|
@bsunanda Giovanni is on vacation this week. I will sign it once my question will be answered. |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
| import HLTrigger.HLTfilters.hltHighLevel_cfi | ||
| hcalminbiasHLT = HLTrigger.HLTfilters.hltHighLevel_cfi.hltHighLevel.clone( | ||
| # HLTPaths = ['HLT_HcalPhiSym'], | ||
| eventSetupPathsKey='HcalCalMinBiasHI', | ||
| throw = False #dont throw except on unknown path name | ||
| ) | ||
|
|
||
| seqALCARECOHcalCalMinBias = cms.Sequence(hcalminbiasHLT*hcalDigiAlCaMB*gtDigisAlCaMB*hbherecoNoise*hfrecoNoise*hfrecoMBspecial*horecoNoise) | ||
| import RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi | ||
| hbherecoNoise = RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi.hbheprereco.clone( |
There was a problem hiding this comment.
Hi @bsunanda - can the duplicate module definitions (eg, hbherecoNoise) be consolidated into a cfi that both cffs can use?
cmsbuild
added
alca-pending
comparison-pending
pending-signatures
tests-pending
and removed
fully-signed
tests-approved
labels
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
@arunhep Could you try to approve this after I made the changes as suggested by David |
|
@bsunanda please let the tests and comparison finish. after that I will check and sign. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
+1 |
Changes in view of recent changes in HCAL reconstruction sequence changes