Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made MagGeometry thread safe #1837

Merged
merged 1 commit into from Dec 17, 2013
Merged

Made MagGeometry thread safe #1837

merged 1 commit into from Dec 17, 2013

Conversation

Dr15Jones
Copy link
Contributor

Changed MagGeometry to use an std::atomic<> for its cache of the last volume used. This will allow thread-safe comparisions.
Changed const member functions to return const pointers to member data. This is also needed for thread-safety and was
caught by the static analyzer.
Also changed member data which were pointers to be const pointers in order to help make future maintanence thread-safe.

@Dr15Jones
Made MagGeometry thread safe
0f77253 
Changed MagGeometry to use an std::atomic<> for its cache of the last volume used. This will allow thread-safe comparisions.
Changed const member functions to return const pointers to member data. This is also needed for thread-safety and was
caught by the static analyzer.
Also changed member data which were pointers to be const pointers in order to help  make future maintanence thread-safe.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Made MagGeometry thread safe

It involves the following packages:

MagneticField/Engine
MagneticField/GeomBuilder
MagneticField/VolumeBasedEngine

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Dec 16, 2013

Something wrong with the script that checks mergiability... Looking into that.

@thspeer
Copy link
Contributor

thspeer commented Dec 17, 2013

Working @thspeer

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1837/1811/summary.html

@thspeer
Copy link
Contributor

thspeer commented Dec 17, 2013

+1
tested 0f77253 in CMSSW_7_0_X_2013-12-17-0200_1837
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 17, 2013
@ktf
Merge pull request #1837 from Dr15Jones/makeVolumeCacheInMagFieldThre…
2b29811 
…adSafe

Multithreading fixes -- Made MagGeometry thread safe
@ktf ktf merged commit 2b29811 into cms-sw:CMSSW_7_0_X Dec 17, 2013
@Dr15Jones Dr15Jones deleted the makeVolumeCacheInMagFieldThreadSafe branch December 19, 2013 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @ktf @thspeer