New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow filling in MultiTrackValidator and PackedCandidateTrackValidator #18380
Conversation
@cmsbuild, please test |
type bugfix |
The tests are being triggered in jenkins. |
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DQM/TrackingMonitor @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
This PR fixes
fill(Plot)NoFlow
functions in MultiTrackValidator and PackedCandidateTrackValidator to fill the last bin instead of overflow bin in case of overflow. This is the intention, and is already correctly done for underflows.Thanks to @arizzi for noticing the bug (#18092 (comment)).
Tested in 9_1_0_pre2, expecting changes in MultiTrackValidator and PackedCandidateTrackValidator histograms that are filled with "no under/overflow" (=nearly all) in the last bin.
@rovere @VinInn