Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow filling in MultiTrackValidator and PackedCandidateTrackValidator #18380

Merged
merged 1 commit into from Apr 20, 2017

Conversation

makortel
Copy link
Contributor

This PR fixes fill(Plot)NoFlow functions in MultiTrackValidator and PackedCandidateTrackValidator to fill the last bin instead of overflow bin in case of overflow. This is the intention, and is already correctly done for underflows.

Thanks to @arizzi for noticing the bug (#18092 (comment)).

Tested in 9_1_0_pre2, expecting changes in MultiTrackValidator and PackedCandidateTrackValidator histograms that are filled with "no under/overflow" (=nearly all) in the last bin.

@rovere @VinInn

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Contributor Author

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19211/console Started: 2017/04/18 12:23

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/TrackingMonitor
Validation/RecoTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@hdelanno, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @fioriNTU, @wmtford, @mtosi, @idebruyn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18380/19211/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3329 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1819408
  • DQMHistoTests: Total failures: 19354
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799881
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b68a62 into cms-sw:master Apr 20, 2017
@makortel makortel deleted the fixFillNoFlow branch February 12, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants