Adding me0/gemmuon ID to the muon selectors and for miniAOD #18387
Conversation
|
A new Pull Request was created by @calabria (Cesare Calabria) for master. It involves the following packages: DataFormats/MuonReco @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
assign upgrade |
|
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
| if ( minNumberOfMatches == 0 ) return true; | ||
|
|
||
| int nMatch = 0; | ||
| for ( std::vector<reco::MuonChamberMatch>::const_iterator chamberMatch = muon.matches().begin(); |
There was a problem hiding this comment.
Could be a range-based for loop
| const double trkY = chamberMatch->y; | ||
| const double errY = chamberMatch->yErr; | ||
|
|
||
| for ( std::vector<reco::MuonSegmentMatch>::const_iterator segment = chamberMatch->me0Matches.begin(); segment != chamberMatch->me0Matches.end(); ++segment ) |
There was a problem hiding this comment.
Could be a range-based for loop
| if ( minNumberOfMatches == 0 ) return true; | ||
|
|
||
| int nMatch = 0; | ||
| for ( std::vector<reco::MuonChamberMatch>::const_iterator chamberMatch = muon.matches().begin(); |
There was a problem hiding this comment.
Could be a range-based for loop
| const double trkY = chamberMatch->y; | ||
| const double errY = chamberMatch->yErr; | ||
|
|
||
| for ( std::vector<reco::MuonSegmentMatch>::const_iterator segment = chamberMatch->gemMatches.begin(); segment != chamberMatch->gemMatches.end(); ++segment ) |
There was a problem hiding this comment.
Could be a range-based for loop
| if ( nMatch >= minNumberOfMatches ) return true; | ||
| else return false; | ||
| } // ME0Mu | ||
| if ( type == GEMMu ) |
There was a problem hiding this comment.
This case looks like a duplicate of the previous case with different parameters... code duplication could be reduced by making a common function.
There was a problem hiding this comment.
actually I am not sure if this is really needed, because gemMuons won't be used standalone. Anyway I added a new function because it is not said the two will be the same in the future. I don't think it is the case to spend time on this now, if this can not remain as it is, I will remove it.
| @@ -89,6 +89,10 @@ def miniAOD_customizeCommon(process): | |||
| # | |||
| process.selectedPatJets.cut = cms.string("pt > 10") | |||
| process.selectedPatMuons.cut = cms.string("pt > 5 || isPFMuon || (pt > 3 && (isGlobalMuon || isStandAloneMuon || numberOfMatches > 0 || muonID('RPCMuLoose')))") | |||
|
|
|||
| from Configuration.Eras.Modifier_phase2_muon_cff import phase2_muon | |||
| if phase2_muon.isChosen(): | |||
There was a problem hiding this comment.
Use toModify(), not isChosen()
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
cmsbuild
added
comparison-available
and removed
comparison-pending
comparison-available
tests-approved
labels
cmsbuild
added
comparison-pending
tests-pending
upgrade-pending
and removed
comparison-available
tests-approved
upgrade-approved
labels
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
This is an incremental effect of adding the GEMMuonArbitrated in ttbar PU200:
This is a combined effect of the PR: muons are used in MET significance and it looks like the additions made do not significantly affect the significance in ZMM events (with PU200) Something to be followed up:
|
|
+1
Some follow up PR should also update the slimmedMuons DQM to be aware of the updated selection. |
|
+1 |
Adding me0muon and gemmuon IDs to the muon selectors and saving me0muons with 3 < pt < 5 gev for the miniAOD. Once we have a stable selection, we will add it.
@kpedro88 @HuguesBrun @jshlee @drkovalskyi