Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude more PoolDBOutputService calls from static analyzer #18388

Merged
merged 1 commit into from Apr 18, 2017
Merged

Exclude more PoolDBOutputService calls from static analyzer #18388

merged 1 commit into from Apr 18, 2017

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@Dr15Jones
Copy link
Contributor Author

@gartung please review

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 18, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19219/console Started: 2017/04/18 16:50

@gartung
Copy link
Member

gartung commented Apr 18, 2017

Looks correct to me.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: bea7c0f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18388/19219/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
53a3a48
ac1504b
e59268f
7e96e11
2522867
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18388/19219/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18388/19219/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6 davidlange6 merged commit 12b2a2c into cms-sw:master Apr 18, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18388/19219/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 33 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1819442
  • DQMHistoTests: Total failures: 29352
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1789917
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Dr15Jones Dr15Jones deleted the extendStaticExcludes branch May 4, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @gartung @davidlange6