Update me0Digi validation #18394
Update me0Digi validation #18394
Conversation
|
A new Pull Request was created by @calabria (Cesare Calabria) for master. It involves the following packages: Validation/MuonME0Validation @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
| double pos_helper = 1.0; | ||
| for(int j=0; j<7; ++j) {neutral += neuBkg[j]*pos_helper; pos_helper *= pos;} | ||
| pos_helper = 1.0; | ||
| for(int j=0; j<7; ++j) {charged += eleBkg[j]*pos_helper; pos_helper *= pos;} |
There was a problem hiding this comment.
Couldn't this loop be combined with the previous loop?
|
please test |
|
The tests are being triggered in jenkins. |
|
Pull request #18394 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison job queued. |
| @@ -119,7 +119,7 @@ TH1F* MuonME0DigisHarvestor::ComputeBKG(TH1F* hist1, TH1F* hist2, std::string na | |||
| } | |||
|
|
|||
| int nEvts = hist2->GetEntries(); | |||
| float scale = 6*2*nEvts*9*25e-9; | |||
| float scale = 6*2*nEvts*3*25e-9; | |||
There was a problem hiding this comment.
Hi @calabria - please add a comment to explain this set of magic numbers
There was a problem hiding this comment.
6 layers, 2 endcap regions, we are saving hits only from 3 BXs (-1,0,+1) of 25 ns (before it was 9)
There was a problem hiding this comment.
I meant in the code:) Thanks for adding it
[but can "3" be deduced from some other source of information?]
There was a problem hiding this comment.
at the moment this information can be taken from here https://github.com/cms-sw/cmssw/blob/master/SimMuon/GEMDigitizer/python/muonME0ReDigis_cfi.py#L11 , when we move to the realistic digitizer from similar lines
|
if there are no further comments can we integrate this PR? Thanks. |
|
it is need of adding a comment to the code to explain the line discussed above |
|
Pull request #18394 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
-1 Tested at: fe19ab2 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Adding plots for the expected background rates (given the results from FLUKAxGEANT). Update the binning to match the me0 8 eta-partition geometry.
@kpedro88