Calol2 online dqm 91x

[ashtipliyski]

Adds event by event comparisons by objects generated by Layer 2 of the calorimeter trigger (CALOL2) which is responsible for jets, e/g, tau and sums.

[cmsbuild]

A new Pull Request was created by @ashtipliyski (Antoni Shtipliyski) for master.

It involves the following packages:

DQM/L1TMonitor

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[dmitrijus]

Please don't print anything to std:cout!

[cmsbuild]

Pull request #18397 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #18397 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #18397 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[ashtipliyski]

After deployment at the DQM online playback machine it was noticed that the DQM module was not behaving as expected. To remedy this, the module code was refactored to use endOfLuminosityBlock() instead of endRun() and the module configuration file was modified to replace L1T2016EMU with L1TEMU (already implemented by other L1T PRs deployed at playback machine).

[dmitrijus]

So, I guess there will be a follow-up - implementing endOfLuminosityBlock

[ashtipliyski]

Hi @dmitrijus,

Yes, after our discussion in the CMS control room on Saturday I am currently implementing the "summary" functionality using the DQMEDHarvester::dqmEndLuminosityBlock() method as per your recommendation. Will update the PR as soon as possible.

Cheers

[cmsbuild]

Pull request #18397 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19987/console Started: 2017/05/19 12:57

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

Pull request #18397 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-18397/330

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/22615/console Started: 2017/08/31 15:44

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: cd99957
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18397/22615/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
94fab3e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18397/22615/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18397/22615/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18397/22615/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2656041
• DQMHistoTests: Total failures: 210
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2655642
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[davidlange6]

+1

[smuzaffar]

@ashtipliyski , can you please provide a fix to avoid the following compilation errors for gcc7 IBs
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_9_3_X_2017-09-04-2300/DQM/L1TMonitor

DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc: In member function 'virtual void L1TdeStage2CaloLayer2::analyze(const edm::Event&, const edm::EventSetup&)':
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:341:43: error: variable 'dataEGIt' set but not used [-Werror=unused-but-set-variable]
    l1t::EGammaBxCollection::const_iterator dataEGIt = egDataCol->begin(currBx);
                                           ^~~~~~~~
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:342:43: error: variable 'emulEGIt' set but not used [-Werror=unused-but-set-variable]
    l1t::EGammaBxCollection::const_iterator emulEGIt = egEmulCol->begin(currBx);
                                           ^~~~~~~~
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:344:40: error: variable 'dataTauIt' set but not used [-Werror=unused-but-set-variable]
    l1t::TauBxCollection::const_iterator dataTauIt = tauDataCol->begin(currBx);
                                        ^~~~~~~~~
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:345:40: error: variable 'emulTauIt' set but not used [-Werror=unused-but-set-variable]
    l1t::TauBxCollection::const_iterator emulTauIt = tauEmulCol->begin(currBx);
                                        ^~~~~~~~~
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:347:42: error: variable 'dataSumIt' set but not used [-Werror=unused-but-set-variable]
    l1t::EtSumBxCollection::const_iterator dataSumIt = sumDataCol->begin(currBx);
                                          ^~~~~~~~~
  DQM/L1TMonitor/src/L1TdeStage2CaloLayer2.cc:348:42: error: variable 'emulSumIt' set but not used [-Werror=unused-but-set-variable]
    l1t::EtSumBxCollection::const_iterator emulSumIt = sumEmulCol->begin(currBx);

[ashtipliyski]

Hi @smuzaffar, code to remove unused variables can be found here ashtipliyski@d04e83d.

[smuzaffar]

Ok thanks , I have open a PR #20390