Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivation of fat event filter for uGMT ZS online DQM - 90x v2 #18409

Conversation

thomreis
Copy link
Contributor

Backport from PR #18395

Add the fat event filter (keeps every 107th event) again to the L1 trigger online DQM configuration.
This is needed for the uGMT zero suppression DQM module because for those events the ZS is in validation mode and does only flag and not suppress the data blocks.

In addition the "2016" string was removed from the DQM directory names and the maximum FED readout size was increased.

This PR has the same changes as #18396 and in addition also contains what is already in PR #18043 in order to resolve a conflict when merging for the deployment at P5. The 91x version of #18043 is already merged.

EsmaeelEskandari and others added 7 commits March 8, 2017 09:14
…ectory names.

Conflicts:
	DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py
	DQM/L1TMonitor/python/L1TStage2uGMT_cfi.py

Conflicts:
	DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py
	DQM/L1TMonitor/python/L1TStage2uGMT_cfi.py
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_9_0_X.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @kreczko, @batinkov this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

Why is it 2 times larger than original backport?

@thomreis
Copy link
Contributor Author

@dmitrijus this contains also commits that are already in PR #18043 in order to resolve a conflict at P5.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19520/console Started: 2017/05/02 17:19

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18409/19520/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1884674
  • DQMHistoTests: Total failures: 14531
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1869970
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff03ced into cms-sw:CMSSW_9_0_X May 4, 2017
@thomreis thomreis deleted the uGMT-zero-suppression-config-changes_90x_v2 branch May 4, 2017 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants