Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Tracker Phase2 Digitizer with realisic noise parameters #18421

Merged
merged 1 commit into from Apr 24, 2017

Conversation

suchandradutta
Copy link
Contributor

The noise parameter for signal strips as well as empty (not fired) strips are updated to more realistic values obtained from electronic settings. This change is done for OT modules only i.e for PSP, PSS and 2S modules. The change and the corresponding consequences are studied.

NoiseEffectOnDigi_Apr14_2017.pdf

@boudoul @delaere

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

SimTracker/SiPhase2Digitizer

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19304/console Started: 2017/04/20 20:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18421/19304/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3817 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826239
  • DQMHistoTests: Total failures: 24241
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801825
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

+1
Only minor changes to tracking and high-level quantities in the comparison for 2023 workflows, as expected from a change in the noise handling

@civanch
Copy link
Contributor

civanch commented Apr 24, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d2f4f99 into cms-sw:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants