New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Tracker Phase2 Digitizer with realisic noise parameters #18421
Updating Tracker Phase2 Digitizer with realisic noise parameters #18421
Conversation
A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
The noise parameter for signal strips as well as empty (not fired) strips are updated to more realistic values obtained from electronic settings. This change is done for OT modules only i.e for PSP, PSS and 2S modules. The change and the corresponding consequences are studied.
NoiseEffectOnDigi_Apr14_2017.pdf
@boudoul @delaere