Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a small producer that selects L1's that did not result on a L2 (back port of #18414) #18423

Merged

Conversation

folguera
Copy link
Contributor

Backport of #18414 so it can be used in ConfDB.

… so they can be used to recover those events failing L2 reconstruction.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @folguera (Santiago Folgueras) for CMSSW_9_0_X.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19297/console Started: 2017/04/20 16:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18423/19297/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1884626
  • DQMHistoTests: Total failures: 44280
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1840173
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@folguera
Copy link
Contributor Author

@davidlange6 @Martin-Grunewald, @smuzaffar do we have an estimate on when this would be merged, we do need this to be inside CMSSW to be ported to ConfDB and finish the Muon HLT template for 2017

@Martin-Grunewald
Copy link
Contributor

It has been requested several times. The equivalent PR is already in 91X and will thus be in 910pre3.
We'll move HLT development to that pre-release anyway. In the meantime you could work offline with
a python file so that things are ready to go.

@folguera
Copy link
Contributor Author

This is what I've been doing, and I believe things are ready to go but I cannot import them to ConfDB until this is merged.

@davidlange6
Copy link
Contributor

+1

"several times"would appear to be once on Tuesday...(which was the first opportunity after the 91x version got merged)

@cmsbuild cmsbuild merged commit cb650f6 into cms-sw:CMSSW_9_0_X Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants