Explicitly register to produce on end transition

[Dr15Jones]

All modules which produce on end Run or end LuminosityBlock now explicitly call produces with that information. This is needed to properly schedule modules in upcoming framework changes.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Alignment/LaserAlignment
Alignment/MillePedeAlignmentAlgorithm
Calibration/TkAlCaRecoProducers
CommonTools/UtilAlgos
DPGAnalysis/Skims
DQMServices/Components
EventFilter/L1GlobalTriggerRawToDigi
GeneratorInterface/BeamHaloGenerator
GeneratorInterface/Core
GeneratorInterface/CosmicMuonGenerator
GeneratorInterface/LHEInterface
GeneratorInterface/TauolaInterface
HLTrigger/HLTcore
IOMC/ParticleGuns
RecoLuminosity/LumiProducer
TauAnalysis/MCEmbeddingTools
Validation/GlobalHits

@ghellwig, @cerminar, @fabozzi, @Martin-Grunewald, @rekovic, @dmitrijus, @govoni, @perrotta, @civanch, @vanbesien, @silviodonato, @cmsbuild, @fwyzard, @GurpreetSinghChahal, @davidlange6, @mdhildreth, @slava77, @mmusich, @mulhearn, @arunhep, @perrozzi, @thuer, @monttj, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @barvic, @mkirsano, @makortel, @tocheng, @Martin-Grunewald, @agrohsje, @tlampen, @mschrode, @mmusich, @threus this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19307/console Started: 2017/04/20 23:15

[Dr15Jones]

This change causes no functional behavior changes, it is just anticipating a change to the framework.

[cmsbuild]

-1

Tested at: ac99678

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18427/19307/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/TauAnalysis/MCEmbeddingTools/plugins/TrackMergeremb.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/TauAnalysis/MCEmbeddingTools/plugins/EmbeddingVertexCorrector.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/TauAnalysis/MCEmbeddingTools/plugins/MuMuForEmbeddingSelector.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/GeneratorInterface/Pythia6Interface/plugins/Pythia6HadronizerFilter.cc:3:0:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/GeneratorInterface/Core/interface/HadronizerFilter.h: In constructor 'edm::HadronizerFilter::HadronizerFilter(const edm::ParameterSet&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/GeneratorInterface/Core/interface/HadronizerFilter.h:164:33: error: 'Transtion' is not a member of 'edm'
     produces();
                                 ^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/GeneratorInterface/Core/interface/HadronizerFilter.h:164:33: error: 'Transtion' is not a member of 'edm'
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-04-20-1100/src/GeneratorInterface/Core/interface/HadronizerFilter.h:164:5: error: parse error in template argument list
     produces();


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18427/19310/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3308 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1826239
• DQMHistoTests: Total failures: 45547
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1780519
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[Martin-Grunewald]

+1

[ghellwig]

+1

[perrozzi]

+1

[dmitrijus]

+1

[fabozzi]

+1

[civanch]

+1

[slava77]

+1

for #18427 f987d94

• reco is only in RecoLuminosity/LumiProducer/plugins/LumiProducer.cc : the begin/end transitions are assigned correctly for the run/lumi products
• jenkins tests pass

[rekovic]

+1