Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SV userFloats from slimmedJets in MiniAOD #18439

Conversation

ferencek
Copy link
Contributor

Following discussion in today's RECO/AT meeting (https://indico.cern.ch/event/632452/), this PR removes userFloats from slimmedJets in MiniAOD that store properties of AVR secondary vertices.

@arizzi

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Apr 21, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19329/console Started: 2017/04/21 23:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18439/19329/summary.html

Comparison Summary:

  • You potentially added 31 lines to the logs
  • Reco comparison results: 1660 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826205
  • DQMHistoTests: Total failures: 24036
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1801996
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 25, 2017

+1

for #18439 08016f9

  • implemented as described
  • jenkins tests pass and comparisons with baseline show no differences
  • based on a local copy of jenkins output for 136.731 (100 events) there is a reduction in the miniAOD file in the size of slimmedJets by 43 bytes/evt (2% of the slimmedJets size and 0.1% of the file size; the larger sample average will likely be smaller due to compression).

@davidlange6 davidlange6 merged commit f16bb58 into cms-sw:master Apr 25, 2017
@ferencek ferencek deleted the RemoveSVUserFloatsFromMiniAOD-PR_from-CMSSW_9_1_0_pre2 branch May 2, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants