Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modification of cone based tau algorithm to furbish it as fallback solution for the HLT for upcoming data taking (90X version) #18441

Closed
wants to merge 11 commits into from
Closed

Modification of cone based tau algorithm to furbish it as fallback solution for the HLT for upcoming data taking (90X version) #18441

wants to merge 11 commits into from

Conversation

roger-wolf
Copy link
Contributor

Dear colleagues,

this is the 90X equivalent PR of #18429. See comments there for reference.

Cheers,
Roger

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Apr 22, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2017 •
edited by smuzaffar

A new Pull Request was created by @roger-wolf (Roger Wolf) for CMSSW_9_0_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Apr 22, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19330/console Started: 2017/04/22 14:54

@cmsbuild
Copy link
Contributor

+1
Tested at: c9b971f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19330/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c9b971f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19330/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19330/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19330/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1884626
  • DQMHistoTests: Total failures: 14530
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1869923
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #18441 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #18441 was updated. @perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please check and sign again.

@mbluj
Copy link
Contributor

mbluj commented Apr 28, 2017 •
edited

The PR was updated to align with changes introduced to its 91X sibling #18429.
Could you please start tests?

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19459/console Started: 2017/04/28 15:24

@cmsbuild
Copy link
Contributor

+1
Tested at: c0dc282
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19459/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c0dc282
554ab40
62ea1f2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19459/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19459/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18441/19459/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1884674
  • DQMHistoTests: Total failures: 44282
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1840219
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1
New features needed for possible HLT development, do not modify current behaviour.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

Closing PR. CMSSW_9_0_X development has completed (CMSSW_9_2_X is for data taking)

@mbluj mbluj deleted the CMSSW_9_0_X_tau-pog_coneBaseTaus branch October 10, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved orp-pending reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@roger-wolf @cmsbuild @slava77 @perrotta @mbluj @Martin-Grunewald @davidlange6