-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O2O for Ecal Alignment #18466
O2O for Ecal Alignment #18466
Conversation
A new Pull Request was created by @depasse for master. It involves the following packages: CondTools/Ecal @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@depasse |
Hi Giacomo,
For the moment, it is just technical, not an Ecal will.
The aim is eventually to deploy O2O for EcalPedestals and EcalAlignment (always when switching Bon/Boff, for express and hlt).
You will have to use similar commands in EcalTPG.sh as those you used for ADCToGeV or IntercalibConstants.
But I'm wondering if the delay introduced by these (4) new commands will not be too long (as they are launched at the beginning of the run). Do you have a measurement of this (maybe a test on ADCToGeV ?) ?
I'm waiting for the sentiment of Ecal managers before going further.
Thanks.
Pierre
…________________________________
From: ggovi [notifications@github.com]
Sent: 02 May 2017 17:06
To: cms-sw/cmssw
Cc: Pierre Depasse; Mention
Subject: Re: [cms-sw/cmssw] O2O for Ecal Alignment (#18466)
@depasse<https://github.com/depasse>
the implementation looks ok to me, but we should discuss the deployment plan . Can you please provide context and plan at the next AlcaDB meeting, monday May 8.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18466 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEaCWy8zsAGL9CgNIiPsmeBM5U-Ugv6yks5r10ZagaJpZM4NHr7I>.
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Automatic switching Bon/Boff with O2O for Ecal Alignment (EB, EE and ES)