Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2O for Ecal Alignment #18466

Merged
merged 1 commit into from
May 9, 2017
Merged

O2O for Ecal Alignment #18466

merged 1 commit into from
May 9, 2017

Conversation

depasse
Copy link
Contributor

@depasse depasse commented Apr 25, 2017

Automatic switching Bon/Boff with O2O for Ecal Alignment (EB, EE and ES)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @argiro this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented May 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19494/console Started: 2017/05/02 11:39

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18466/19494/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3306 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778721
  • DQMHistoTests: Total failures: 33407
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1745141
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ggovi
Copy link
Contributor

ggovi commented May 2, 2017

@depasse
the implementation looks ok to me, but we should discuss the deployment plan . Can you please provide context and plan at the next AlcaDB meeting, monday May 8.

@depasse
Copy link
Contributor Author

depasse commented May 2, 2017 via email

@smuzaffar smuzaffar modified the milestones: CMSSW_9_2_X, CMSSW_9_1_X May 4, 2017
@ggovi
Copy link
Contributor

ggovi commented May 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8359aa3 into cms-sw:master May 9, 2017
@depasse depasse deleted the EcalO2OAlignment branch February 14, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants