Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Data Format for BST record from TCDS raw, and use it to revive beam information, physics declared bit, and HLT event selection for online DQM #18470

Merged
merged 15 commits into from Apr 27, 2017

Conversation

dmitrijus
Copy link
Contributor

Backport of #18108

Salvatore Di Guida added 15 commits April 26, 2017 10:10
…ilities/plugins/testGlobalNumbers.cc.

(cherry picked from commit 59940da)
… FED data from RAW data tier.

(cherry picked from commit b126bb6)
…face/interface/FED1024.h in order to avoid issues with padding.

(cherry picked from commit 0e81482)
…the FED1024 raw data using the utilities in EventFilter/Utilities package.

(cherry picked from commit bf6bc8b)
…n in the DQM input source DQMStreamerReader.

(cherry picked from commit 2eaa90d)
…r/Utilities/test/testGlobalNumbers.cc, and add a BuildFile in EventFilter/Utilities/test.

(cherry picked from commit 40b8ce4)
…rit from edm::one::EDAnalyzer<>.

(cherry picked from commit de8d45b)
….cc, and further improve logging.

(cherry picked from commit a968de2)
…of the histograms populated by DQMServices/Components/src/DQMProvInfo.h

(cherry picked from commit 19b3171)
…ing with the beams at the energy allowed for physics production in DQMServices/Components/src/DQMProvInfo.h and DQMServices/Components/src/DQMProvInfo.cc

(cherry picked from commit af83f87)
…l it in TCDSRawToDigi, fetch it in DQMProvInfo.

(cherry picked from commit 355a5c6)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_9_0_X.

It involves the following packages:

DQM/Integration
DQMServices/Components
DataFormats/Scalers
EventFilter/FEDInterface
EventFilter/Utilities

@perrotta, @emeschi, @dmitrijus, @cmsbuild, @rekovic, @slava77, @mommsen, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic, @threus, @batinkov this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor Author

+1

@dmitrijus
Copy link
Contributor Author

type backport

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19403/console Started: 2017/04/26 10:21

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18470/19403/summary.html

There are some workflows for which there are errors in the baseline:
1306.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1735705
  • DQMHistoTests: Total failures: 29349
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1706193
  • DQMHistoTests: Total skipped: 163
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 26, 2017

backport of #18108

looks like this text in the PR description is not enough for the bot to react .. or, maybe it's the capitalization

@slava77
Copy link
Contributor

slava77 commented Apr 26, 2017

+1

for #18470 c398400

I guess that in commissioning we do not strictly require dataset version change, else it will need to happen with this change deployed.

@davidlange6 davidlange6 merged commit bda6542 into cms-sw:CMSSW_9_0_X Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants