Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of try-catch in CSCTriggerPrimitivesProducer #18487

Merged
merged 1 commit into from May 3, 2017
Merged

get rid of try-catch in CSCTriggerPrimitivesProducer #18487

merged 1 commit into from May 3, 2017

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 26, 2017

@Dr15Jones @kpedro88 it could take a while before the memory issues in the CSCTriggerPrimitives package are solved (#18259) so I made this pull request to address the outdated "try-catch" of GEM/RPCGeometry.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @kreczko, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

@cmsbuild please test
@dildick thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19426/console Started: 2017/04/26 22:18

@cmsbuild
Copy link
Contributor

-1

Tested at: 1959dc8

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f536883
588aa71
35ee5e1
1ccb4fb
09d082d
f032f1b
81f6293
00fbb35
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f536883
588aa71
35ee5e1
1ccb4fb
09d082d
f032f1b
81f6293
00fbb35
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@dildick
Copy link
Contributor Author

dildick commented Apr 27, 2017

error is not related to PR

27-Apr-2017 01:31:26 CEST  Initiating request to open file file:ttbarForMetTests.root
----- Begin Fatal Exception 27-Apr-2017 01:31:27 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'ttbarForMetTests.root'
   Additional Info:
      [a] Input file file:ttbarForMetTests.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
+ die 'Failure using recoMET_caloMet_cfg.py' 84
+ echo Failure using recoMET_caloMet_cfg.py: status 84
Failure using recoMET_caloMet_cfg.py: status 84
+ exit 84
status = 21504

---> test testRecoMETMETProducers had ERRORS

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19426/summary.html

Comparison Summary:

  • You potentially added 176 lines to the logs
  • Reco comparison results: 3372 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1783647
  • DQMHistoTests: Total failures: 31664
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 1751803
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Apr 28, 2017

@kpedro88 could you run the tests again?

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19471/console Started: 2017/04/28 19:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18487/19471/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778755
  • DQMHistoTests: Total failures: 17132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1761450
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented May 2, 2017

@rekovic please sign

@rekovic
Copy link
Contributor

rekovic commented May 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6ef98e6 into cms-sw:master May 3, 2017
@dildick dildick deleted the patch-5 branch May 8, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants