New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of try-catch in CSCTriggerPrimitivesProducer #18487
Conversation
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The tests are being triggered in jenkins. |
Comparison job queued. |
error is not related to PR 27-Apr-2017 01:31:26 CEST Initiating request to open file file:ttbarForMetTests.root ----- Begin Fatal Exception 27-Apr-2017 01:31:27 CEST----------------------- An exception of category 'FileOpenError' occurred while [0] Constructing the EventProcessor [1] Constructing input source of type PoolSource [2] Calling RootFileSequenceBase::initTheFile() [3] Calling StorageFactory::open() [4] Calling File::sysopen() Exception Message: Failed to open the file 'ttbarForMetTests.root' Additional Info: [a] Input file file:ttbarForMetTests.root could not be opened. [b] open() failed with system error 'No such file or directory' (error code 2) ----- End Fatal Exception ------------------------------------------------- + die 'Failure using recoMET_caloMet_cfg.py' 84 + echo Failure using recoMET_caloMet_cfg.py: status 84 Failure using recoMET_caloMet_cfg.py: status 84 + exit 84 status = 21504 ---> test testRecoMETMETProducers had ERRORS |
Comparison is ready Comparison Summary:
|
@kpedro88 could you run the tests again? |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@rekovic please sign |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
@Dr15Jones @kpedro88 it could take a while before the memory issues in the CSCTriggerPrimitives package are solved (#18259) so I made this pull request to address the outdated "try-catch" of GEM/RPCGeometry.