Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to consumes interface and getByToken for TrackerSeedGenerator #1849

Merged
merged 1 commit into from Dec 18, 2013

Conversation

thspeer
Copy link
Contributor

@thspeer thspeer commented Dec 17, 2013

Update of #1811 with rebase, there were conflicts with the Muon PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thspeer for CMSSW_7_0_X.

Changes to consumes interface and getByToken for TrackerSeedGenerator

It involves the following packages:

RecoMuon/TrackerSeedGenerator
RecoPixelVertexing/PixelTrackFitting
RecoTracker/ConversionSeedGenerators
RecoTracker/SpecialSeedGenerators
RecoTracker/TkSeedGenerator

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

@thspeer
Copy link
Contributor Author

thspeer commented Dec 18, 2013

+1
Tested 10a2578 in CMSSW_7_0_X_2013-12-18-0200_1849
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 18, 2013
Reco updates -- Changes to consumes interface and getByToken for TrackerSeedGenerator
@ktf ktf merged commit 91a121e into cms-sw:CMSSW_7_0_X Dec 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants