Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize DetId parsing in TrackingNtuple #18491

Merged
merged 5 commits into from May 3, 2017

Conversation

makortel
Copy link
Contributor

This PR makes the DetId parsing in TrackingNtuple more agnostic on the detector geometry by parsing the fields in the ntuplizer with TrackerTopology, and storing all the fields in separate branches. Straightforward implementation would have lead to some amount of copy-paste because pix_* branches have BPix/FPix hits, str_* and ph2_* TIB/TID/TOB/TEC hits, and inv_* and simhit_* hits from all subdetectors, so I went a bit creative.

This PR is a successor of #18403 (which attempted to serialize the TrackerTopology constants and do the parsing on the ntuple analysis code).

I also included a small fix in the ntuple python library by @ebrondol (da8d834)

Tested in 9_1_0_pre2, no changes expected.

@rovere @VinInn @ebrondol

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Validation/RecoTrack

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19432/console Started: 2017/04/27 10:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #18491 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor Author

Removed one bogus import that didn't give errors on my local area (thanks @ebrondol!)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18491/19432/summary.html

Comparison Summary:

  • You potentially added 59 lines to the logs
  • Reco comparison results: 3362 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1783647
  • DQMHistoTests: Total failures: 32026
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1751448
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #18491 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@makortel
Copy link
Contributor Author

Added another commit, to show the phase2 OT barrel tilted side as part the layer string in the default hit list printouts (thanks to @ebrondol for the suggestion and testing it).

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19439/console Started: 2017/04/27 15:17

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18491/19439/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3326 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1783647
  • DQMHistoTests: Total failures: 31416
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1752058
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b4b0408 into cms-sw:master May 3, 2017
@makortel makortel deleted the ntupleGeneralizeDetId_v2 branch February 12, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants