New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize DetId parsing in TrackingNtuple #18491
Conversation
… detectors Had to be a bit creative to minimize copy-paste.
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Validation/RecoTrack @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Pull request #18491 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
Removed one bogus import that didn't give errors on my local area (thanks @ebrondol!) |
Comparison is ready Comparison Summary:
|
Pull request #18491 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
Added another commit, to show the phase2 OT barrel tilted side as part the layer string in the default hit list printouts (thanks to @ebrondol for the suggestion and testing it). |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
This PR makes the DetId parsing in TrackingNtuple more agnostic on the detector geometry by parsing the fields in the ntuplizer with TrackerTopology, and storing all the fields in separate branches. Straightforward implementation would have lead to some amount of copy-paste because
pix_*
branches have BPix/FPix hits,str_*
andph2_*
TIB/TID/TOB/TEC hits, andinv_*
andsimhit_*
hits from all subdetectors, so I went a bit creative.This PR is a successor of #18403 (which attempted to serialize the TrackerTopology constants and do the parsing on the ntuple analysis code).
I also included a small fix in the ntuple python library by @ebrondol (da8d834)
Tested in 9_1_0_pre2, no changes expected.
@rovere @VinInn @ebrondol