Moving the Prescale ES producer to the new parser and deleting old XML parser

[kkotov]

New XML parser take over everything now. Old one is removed.

[cmsbuild]

A new Pull Request was created by @kkotov (Khristian Kotov) for master.

It involves the following packages:

L1Trigger/L1TCommon
L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19727/console Started: 2017/05/10 17:54

[cmsbuild]

-1

Tested at: 14e4ffd

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18517/19727/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMEtaProcessor.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMAssignmentUnit.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMERS.cc 
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/interface/L1TMuonBarrelParamsHelper.h:22:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1TMuonBarrelParamsHelper.cc:1:
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/poison/L1Trigger/L1TCommon/interface/XmlConfigReader.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
 #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
  ^
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMSecProcMap.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMEUX.cc 
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-09-2300/src/L1Trigger/L1TMuonBarrel/src/L1MuBMTrackSegLoc.cc 


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #18517 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

[kkotov]

Although I removed the two lines failing the compilation, for some reason I cannot check how it compiles in my local installation of CMSSW_9_1_0_pre3. I see scram warnings:
****WARNING: Invalid tool FWCore/Framework. Please fix src/L1Trigger/L1TMuonBarrel/src/BuildFile.xml file.
and them multiple linking errors complaining on a missing "edm::Exception::throwThis" symbol. I am giving up as it is beyond my expertise and I only hope it'll compile fine here.

[kkotov]

@rekovic , could you trigger the tests again, please?

[rekovic]

please test

[Martin-Grunewald]

@kkotov
Please raise it at the next TSG meeting...

[cmsbuild]

Pull request #18517 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

[kkotov]

@Martin-Grunewald , I'll try to ping Vladimir today-tomorrow again. In the end no one from TSG can sign-off this PR.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20162/console Started: 2017/05/29 11:17

[kkotov]

@Martin-Grunewald , Thanks for triggering the tests!

[cmsbuild]

+1
Tested at: ce69d0d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18517/20162/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18517/20162/summary.html

Comparison Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 1714 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1840389
• DQMHistoTests: Total failures: 56834
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1783375
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1