B-tag DQM/Val.: Add efficiency plots vs. eta and phi for cut on discriminators #18518
Conversation
|
A new Pull Request was created by @swertz (Sbastien Wertz) for master. It involves the following packages: DQMOffline/RecoB @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
hi all - what is the status of this PR? ( no comments for 3 weeks) |
|
Inclusion in 92X would be welcome... Is there anything you're not happy about? |
|
@dmitrijus - any plans to review this? |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
-1 Tested at: eb9325d You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log9.0 step4 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log25.0 step4 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log50202.0 step4 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step4_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log25202.0 step4 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log23234.0 step4 runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFull_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18/step4_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFull_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
-1 |
|
Pull request #18518 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
Indeed, you should not put those pointers in a shared_ptr or unique_ptr,
because you do not own them and should never delete them: the DQMStore owns
the MEs and the underlying TH1 objects.
.A
|
|
I have a commit ready moving everything to smart pointers. Would you prefer me to open a separate PR or can I push here (it's a lot of changes not directly related to this PR)? |
|
Ideally here, so it does not have to go through the entire slow review process. |
|
Done! I've also removed some duplicate code and simplified things in a few places. |
|
Pull request #18518 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
This PR adds a few monitored quantities to the b-tagging offline DQM and validation: differential efficiencies versus jet Eta and Phi, for a cut on the CSVv2, cMVAv2, CvsL and CvsB discriminators corresponding to the present Loose working points.
This is similar to #18413, where those quantities were added to the HLT DQM.
I've removed some tabs and fixed the indentation where I encountered eye-piercing inconsistencies, hence the large diff when the actual changes are small.