New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecal pedestal pcl90 x #18563
Ecal pedestal pcl90 x #18563
Conversation
A new Pull Request was created by @argiro for CMSSW_9_0_X. It involves the following packages: Calibration/EcalCalibAlgos @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: d92853f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests: ---> test TestConfigDP had ERRORS
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step4_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
sorry, I forgot to commit a file, fixed
… On 4 May 2017, at 16:38, cmsbuild ***@***.***> wrote:
-1
Tested at: d92853f
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18563/19570/summary.html
I found follow errors while testing this PR
Failed tests: UnitTests RelVals
• Unit Tests:
I found errors in the following unit tests:
---> test TestConfigDP had ERRORS
• RelVals:
When I ran the RelVals I found an error in the following worklfows:
1001.0 step4
runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step4_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
please test |
The tests are being triggered in jenkins. |
thanks @franzoni, done
… On 5 May 2017, at 10:46, Giovanni Franzoni ***@***.***> wrote:
@franzoni commented on this pull request.
In Configuration/DataProcessing/Impl/AlCaTestEnable.py:
> @@ -0,0 +1,95 @@
+#!/usr/bin/env python
hello @argiro
this file needs to go here:
Configuration/DataProcessing/python/Impl/AlCaTestEnable.py
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Backport of Ecal Pedestal PCL (#18332,#18512, #18241) to 9_0_X