Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal pedestal pcl90 x #18563

Merged
merged 5 commits into from May 10, 2017
Merged

Ecal pedestal pcl90 x #18563

merged 5 commits into from May 10, 2017

Conversation

argiro
Copy link
Contributor

@argiro argiro commented May 4, 2017

Backport of Ecal Pedestal PCL (#18332,#18512, #18241) to 9_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @argiro for CMSSW_9_0_X.

It involves the following packages:

Calibration/EcalCalibAlgos
Configuration/AlCa
Configuration/DataProcessing
Configuration/EventContent
Configuration/StandardSequences

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

franzoni commented May 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19570/console Started: 2017/05/04 15:46

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

-1

Tested at: d92853f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18563/19570/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
1001.0 step4

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step4_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Pull request #18563 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@argiro
Copy link
Contributor Author

argiro commented May 4, 2017 via email

@franzoni
Copy link

franzoni commented May 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19577/console Started: 2017/05/04 18:48

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Pull request #18563 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@argiro
Copy link
Contributor Author

argiro commented May 5, 2017 via email

@franzoni
Copy link

franzoni commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19597/console Started: 2017/05/05 13:33

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18563/19597/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1883883
  • DQMHistoTests: Total failures: 2041
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1881669
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@franzoni
Copy link

franzoni commented May 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 68f6721 into cms-sw:CMSSW_9_0_X May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants