Avoid undefined behavior in PtrVectorBase.h

[davidlt]

Solves the following:

PtrVectorBase.h:155:14: warning: binding dereferenced null pointer
to reference has undefined behavior [-Wnull-dereference]

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[cmsbuild]

A new Pull Request was created by @davidlt for master.

It involves the following packages:

DataFormats/Common

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @ebrondol, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

thanks

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19572/console Started: 2017/05/04 17:01
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19576/console Started: 2017/05/04 17:22

[cmsbuild]

-1

Tested at: 0284491

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
aae5a1f
55847f1
c658e7f
1e992ec
ccd342b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
aae5a1f
55847f1
c658e7f
1e992ec
ccd342b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18569/19576/summary.html

Comparison Summary:

• You potentially added 38 lines to the logs
• Reco comparison results: 1671 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1829022
• DQMHistoTests: Total failures: 40177
• DQMHistoTests: Total nulls: 21
• DQMHistoTests: Total successes: 1788644
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[Dr15Jones]

The unit test failure is unrelated to this pull request.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar