Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[91X] Geometry-independent MillePede validation #18570

Merged
merged 17 commits into from May 16, 2017
Merged

[91X] Geometry-independent MillePede validation #18570

merged 17 commits into from May 16, 2017

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented May 4, 2017

backport of #18550

  • make the MillePede-internal validation (MPS validation) properly work for phase-1
  • MPS validation works now also without checking out the MP package
  • added weight information to the MPS validation
  • minor bug fixes for exotic use cases

@gregor-mittag
Added geometry-dependent name-string of StructureType to MillePedeUse…
ddfa707 
…rVariables.
@gregor-mittag
Remove hard-coded geometry-dependent numbers from MPS validation.
d3bc4f2
@gregor-mittag
Clean-up ROOT imports in geometry-part of MPS validation.
6de9915
@gregor-mittag
Automatically get correct structure names instead of hard-coded geome…
80573fd 
…try-dependent names in MPS validation.
@gregor-mittag
Clean up ROOT import in 'mps_validate.py'.
4224846
@gregor-mittag
Cleaned up imports in 'mps_validate.py'.
b811e7e
@gregor-mittag
Use proper booleans in MPS validation.
d29f0fd
@gregor-mittag
Moved template files to 'templates' directory.
a1daabe 
This is also a first step towards running the MPS validation w/o checking out
'Alignment/MillePedeAlignmentAlgorithm'.
@gregor-mittag
Create TrackerTree.root file for each campaign separately.
1f41c01 
 - create it depending on the used tracker geometry
 - allows to use different geometries with the same release area
 - checking out MPS is no longer required to run 'mps_validate.py'
@gregor-mittag
Made 'additionalParser' more robust.
2fa168e
@gregor-mittag
Change plot range default in MPS validation.
fe89965
@gregor-mittag
Check tracker-tree generation for errors during execution.
ff580e5
@gregor-mittag
Preserve weights configuration when force-merging.
fc487b7
@gregor-mittag
Remaining clean-up of ROOT imports in MPS validation.
ffaa1af
@gregor-mittag
Remaining clean-up of imports in MPS validation.
8e7f7e9
@gregor-mittag
Added weight information to MPS validation output.
f48472f
@gregor-mittag
Support also payloads from PREP DB in MPS scripts.
20e1f52
@ghellwig
Copy link
Author

ghellwig commented May 4, 2017

please test

@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19571/console Started: 2017/05/04 17:01

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_1_X.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

+1
Tested at: 20e1f52
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18570/19571/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18570/19571/summary.html

Comparison Summary:

  • You potentially added 45 lines to the logs
  • Reco comparison results: 3372 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1835819
  • DQMHistoTests: Total failures: 33055
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1802584
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@franzoni
Copy link

franzoni commented May 9, 2017

+1
same conclusions as in #18550 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@franzoni
Copy link

hello @davidlange6
would it be possible to have this PR
in the forthcoming 91x release?
Thanks !

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c99d6ca into cms-sw:CMSSW_9_1_X May 16, 2017
@ghellwig ghellwig deleted the mpsvalidate-phase1_91X branch May 17, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved backport comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ghellwig @cmsbuild @franzoni @davidlange6 @gregor-mittag