Fixes for regression in the persistency of std::string payloads #18579

ggovi · 2017-05-05T07:35:48Z

Fix for std::string type matching. A recent compiler change has changed the output of the 'demangler' for the std::string class.
Regression test adapted for execution in IB environment. This test will now run correctly once the above fix will be in a main release

…ion in IB environment.

cmsbuild · 2017-05-05T07:36:05Z

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

ggovi · 2017-05-05T07:43:51Z

superseding #18542
@smuzaffar
this one contains fixes for the std::string persistency ( the demangled name from type_info.name() has changed ) and also the adaptation of the regression test for the IB environment. The execution of the test is fine ( no crash ), but the output will be ok only once the std::string fix reaches the main release referenced by the IBs.
Please let me know if we should disable this test until the fix get in the main release.

ggovi · 2017-05-05T07:48:12Z

please test

cmsbuild · 2017-05-05T07:48:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19585/console Started: 2017/05/05 09:50

smuzaffar · 2017-05-05T08:05:52Z

CondCore/CondDB/test/condTestRegression.py

+              for rel_base_env in ['CMSSW_BASE', 'CMSSW_RELEASE_BASE', 'CMSSW_FULL_RELEASE_BASE' ]:
+                  #print "Looking for: %s = %s " %(rel_base_env,os.getenv(rel_base_env))
+                  if os.getenv(rel_base_env) and os.path.exists(str(os.environ[rel_base_env])+'/%s' %execName):
+                      executable = str(os.environ[rel_base_env])+'/%s' %execName


@ggovi , you should break the loop once executable is found

oops, you're right, thanks.

cmsbuild · 2017-05-05T09:22:31Z

Pull request #18579 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-05T10:03:01Z

-1

Tested at: 0d68899

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18579/19585/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

cmsbuild · 2017-05-05T10:03:05Z

Comparison job queued.

smuzaffar · 2017-05-05T11:28:26Z

please test

cmsbuild · 2017-05-05T11:28:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19596/console Started: 2017/05/05 13:29

cmsbuild · 2017-05-05T13:57:20Z

-1

Tested at: f6de5fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18579/19596/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

cmsbuild · 2017-05-05T13:57:22Z

Comparison job queued.

cmsbuild · 2017-05-05T16:08:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18579/19596/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1700 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1831084
DQMHistoTests: Total failures: 27499
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1803405
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

cmsbuild · 2017-05-09T09:30:53Z

+1
Tested at: f6de5fe
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18579/19660/summary.html

cmsbuild · 2017-05-09T09:30:56Z

Comparison job queued.

ggovi · 2017-05-09T09:41:04Z

+1

cmsbuild · 2017-05-09T09:41:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

ggovi · 2017-05-09T09:42:02Z

@smuzaffar
this will fail in the IB environment, until the fixes reaches a main release... is it ok?

smuzaffar · 2017-05-09T09:57:15Z

@ggovi , which main release?

ggovi · 2017-05-09T10:02:20Z

@smuzaffar
well, the release that the IBs are referencing , in this case to find the executable testReadWritePayloads

davidlange6 · 2017-05-09T11:17:35Z

Hi @ggovi - i would have thought the logic in CondCore/CondDB/test/condTestRegression.py would have been sufficient to find testReadWritePayloads locally (after scram b)

cmsbuild · 2017-05-09T11:38:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18579/19660/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1694 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1831084
DQMHistoTests: Total failures: 26035
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1804868
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

smuzaffar · 2017-05-09T12:17:59Z

@ggovi , I do not see it failing in PR tests and my local tests so looks like it was able to find testReadWritePayloads from the release area. So it looks good to me

-rwxr-xr-x 1 cvmfs cvmfs 179632 Aug 25  2016 /cvmfs/cms.cern.ch/slc6_amd64_gcc493/cms/cmssw/CMSSW_7_6_6/test/slc6_amd64_gcc493/testReadWritePayloads
-rwxr-xr-x 1 cvmfs cvmfs 177600 Dec  2 02:38 /cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_0/test/slc6_amd64_gcc530/testReadWritePayloads
-rwxr-xr-x 1 cvmfs cvmfs 193408 Apr  9 02:27 /cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_0_1/test/slc6_amd64_gcc530/testReadWritePayloads
-rwxr-xr-x 1 cvmfs cvmfs 177608 Feb  2 01:43 /cvmfs/cms.cern.ch/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_0_26/test/slc6_amd64_gcc530/testReadWritePayloads

ggovi · 2017-05-09T13:19:47Z

@davidlange6 @smuzaffar
yes ,that's the idea. Maybe I'm confused then - in what circumstance the IB is not building the test?

smuzaffar · 2017-05-09T14:21:01Z

@ggovi , test fails in IB env where the $LOCALRT/test/$SCRAM_ARCH/testReadWritePayloads does not exist but you change here https://github.com/cms-sw/cmssw/pull/18579/files#diff-44fb5ff277a0e30437f3b786451c29c7R161 should fix it.

davidlange6 · 2017-05-09T16:05:05Z

+1

Fix for std::string type matching. Regression test adapted for execut…

0d68899

…ion in IB environment.

cmsbuild added this to the CMSSW_9_2_X milestone May 5, 2017

cmsbuild added comparison-pending db-pending orp-pending pending-signatures tests-pending labels May 5, 2017

cmsbuild added tests-started and removed tests-pending labels May 5, 2017

smuzaffar reviewed May 5, 2017

View reviewed changes

Fix for loop searching the executable

f6de5fe

cmsbuild added tests-pending and removed tests-started labels May 5, 2017

cmsbuild added tests-started and removed tests-pending labels May 5, 2017

cmsbuild added tests-rejected and removed tests-started labels May 5, 2017

cmsbuild removed the comparison-pending label May 5, 2017

cmsbuild added comparison-pending tests-pending tests-started and removed tests-rejected tests-pending labels May 9, 2017

ggovi mentioned this pull request May 9, 2017

Fixing search for existing executable testReadWritePayloads #18542

Closed

cmsbuild added tests-approved and removed tests-started labels May 9, 2017

cmsbuild removed db-pending pending-signatures labels May 9, 2017

cmsbuild added db-approved fully-signed labels May 9, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 9, 2017

cmsbuild added orp-approved and removed orp-pending labels May 9, 2017

cmsbuild merged commit 816c76a into cms-sw:master May 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes for regression in the persistency of std::string payloads #18579

Fixes for regression in the persistency of std::string payloads #18579

ggovi commented May 5, 2017 •

edited

cmsbuild commented May 5, 2017

ggovi commented May 5, 2017

ggovi commented May 5, 2017

cmsbuild commented May 5, 2017 •

edited

smuzaffar May 5, 2017

ggovi May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

smuzaffar commented May 5, 2017

cmsbuild commented May 5, 2017 •

edited

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 9, 2017

cmsbuild commented May 9, 2017

ggovi commented May 9, 2017

cmsbuild commented May 9, 2017

ggovi commented May 9, 2017

smuzaffar commented May 9, 2017

ggovi commented May 9, 2017

davidlange6 commented May 9, 2017

cmsbuild commented May 9, 2017

smuzaffar commented May 9, 2017

ggovi commented May 9, 2017

smuzaffar commented May 9, 2017

davidlange6 commented May 9, 2017

Fixes for regression in the persistency of std::string payloads #18579

Fixes for regression in the persistency of std::string payloads #18579

Conversation

ggovi commented May 5, 2017 • edited

cmsbuild commented May 5, 2017

ggovi commented May 5, 2017

ggovi commented May 5, 2017

cmsbuild commented May 5, 2017 • edited

smuzaffar May 5, 2017

Choose a reason for hiding this comment

ggovi May 5, 2017

Choose a reason for hiding this comment

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

smuzaffar commented May 5, 2017

cmsbuild commented May 5, 2017 • edited

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 5, 2017

cmsbuild commented May 9, 2017

cmsbuild commented May 9, 2017

ggovi commented May 9, 2017

cmsbuild commented May 9, 2017

ggovi commented May 9, 2017

smuzaffar commented May 9, 2017

ggovi commented May 9, 2017

davidlange6 commented May 9, 2017

cmsbuild commented May 9, 2017

smuzaffar commented May 9, 2017

ggovi commented May 9, 2017

smuzaffar commented May 9, 2017

davidlange6 commented May 9, 2017

ggovi commented May 5, 2017 •

edited

cmsbuild commented May 5, 2017 •

edited

cmsbuild commented May 5, 2017 •

edited