Modification of cone based tau algorithm to furbish it as fallback solution for the HLT for upcoming data taking (91X)

[mbluj]

Dear colleagues,

this is a backport of #18429 which has just been merged to newly opened 92X (current master). For convenience I quote description of the original PR:

Dear colleagues,

this is a pull request by @mbluj that contains modifications of the cone based tau reconstruction algorithm as used for the HLT to make it fit for upcoming data taking periods, as fallback in case that the planned HPS-port to the HLT won't be ready in time. I'm citing Michal's comments (*) and refer to him for further questions.

Cheers,
Roger

(*)
This PR is to modify the Cone-based tau builder (used at HLT) to fill some additional data members of produced PFTau not filled so far:

• Size of signal cone (cone for PiZeros used);
• Pt carried by signal PiZeros outside of the signal cone; it is important shape variable supporting isolation in rejecting jet->tau fakes;
• Charge, pdgId, tau decay mode hypothesis.

The changes do not modify current HLT work-flow (the builder is used only at HLT), but provides new features (cf. 2) allowing better jet->tau fake rejection during 2017 data-taking.

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_9_1_X.

It involves the following packages:

HLTrigger/Configuration
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19589/console Started: 2017/05/05 10:52

[cmsbuild]

+1
Tested at: ceb94d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18581/19589/summary.html

[cmsbuild]

Comparison job queued.

[perrotta]

+1
Identical to #18429, already approved (in origin for 91X)

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18581/19589/summary.html

Comparison Summary:

• You potentially added 22 lines to the logs
• Reco comparison results: 1697 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1831050
• DQMHistoTests: Total failures: 42367
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1788503
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[davidlange6]

+1