Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New E/g HLT Pixel Matching : 91X (really for 91X this time) #18582

Merged
merged 19 commits into from May 8, 2017

Conversation

Sam-Harper
Copy link
Contributor

This is the 91X flavour of #18541 which ended up going for 92X.

This PR is unfortunately necessary to be able to run the E/gamma HLT efficiently with the phaseI pixels and as such needs to be 91X.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @Sam-Harper for CMSSW_9_1_X.

It involves the following packages:

DataFormats/EgammaReco
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaHLTProducers

@perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@HuguesBrun, @lgray, @calderona, @rafaellopesdesa, @battibass this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19591/console Started: 2017/05/05 11:31

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@perrotta
Copy link
Contributor

perrotta commented May 5, 2017

+1
Identical to #18541, already approved for the master

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18582/19591/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1705 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 55793
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1775077
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1
but lets try to identify such low level changes needed before making the last open release next time. Thanks

@cmsbuild cmsbuild merged commit b7321f8 into cms-sw:CMSSW_9_1_X May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants