Run2-hcx126 Reorder the xml files for HCAL to conform to the new idea

[bsunanda]

Most of the scenario files are updated and tested

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19595/console Started: 2017/05/05 13:06

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData
Geometry/MuonCommonData
SimG4CMS/Calo
SimG4CMS/HcalTestBeam

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 935dc17

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18586/19595/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test test2023Geometry had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Pull request #18586 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19600/console Started: 2017/05/05 14:32

[cmsbuild]

Pull request #18586 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: dcf4ff4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18586/19600/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19640/console Started: 2017/05/08 15:11

[ianna]

+1

[kpedro88]

+1

[cmsbuild]

+1
Tested at: b031378
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18586/19640/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18586/19640/summary.html

There are some workflows for which there are errors in the baseline:
23234.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• You potentially added 2309 lines to the logs
• Reco comparison results: 1689 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1778044
• DQMHistoTests: Total failures: 41556
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1736315
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[bsunanda]

@

[bsunanda]

@davidlange6 Please merge this version

[davidlange6]

+1

[slava77]

did this PR change geometry or was it just refactoring?

[davidlange6]

is only refactoring

…

On May 18, 2017, at 8:13 PM, Slava Krutelyov ***@***.***> wrote: did this PR change geometry or was it just refactoring? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.