Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breing back "Run modules concurrently during global begin transitions" #18587

Merged

Conversation

Dr15Jones
Copy link
Contributor

This reverts commit e262923.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19604/console Started: 2017/05/05 15:48

@Dr15Jones
Copy link
Contributor Author

@davidlange6 would you like this in CMSSW_9_2_X or CMSSW_9_2_DEVEL_X? I believe I've fixed all the thread-safety items found in the first try, but there could be others.

@davidlange6
Copy link
Contributor

davidlange6 commented May 5, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

-1

Tested at: ceeca66

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a5633ad
abdea55
4c8ecd1
3725cb2
a6ea558
f743c4d
348af6b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a5633ad
abdea55
4c8ecd1
3725cb2
a6ea558
f743c4d
348af6b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

The unit test failure is unrelated to this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18587/19604/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3660 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 19006
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1811864
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

ready to sign this @Dr15Jones ?

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 61124b7 into cms-sw:master May 9, 2017
@Dr15Jones Dr15Jones deleted the revertRevertOfConcurrentGlobal branch May 18, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants