Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compilation problems for Geant4 10.3 #18590

Merged
merged 1 commit into from May 9, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented May 5, 2017

When compile Geant4 10.3 few problems appears in files which used rarely. Trivial fixes should resolve these issues.

No effect on SIM or FastSIM production or on alignment.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

Alignment/LaserAlignmentSimulation
FastSimulation/MaterialEffects
SimG4Core/GFlash

@ghellwig, @civanch, @lveldere, @arunhep, @ssekmen, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @tocheng, @Martin-Grunewald, @mschrode, @matt-komm this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19610/console Started: 2017/05/05 19:39

@civanch civanch changed the title Fixed compillation problems for Geant4 10.3 Fixed compilation problems for Geant4 10.3 May 5, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@civanch
Copy link
Contributor Author

civanch commented May 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18590/19610/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3366 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 47840
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1783064
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@civanch
Copy link
Contributor Author

civanch commented May 6, 2017

@franzoni, @mmusich, this PR is really trivial and only provides compilation for few files.

@arunhep
Copy link
Contributor

arunhep commented May 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a77f98b into cms-sw:master May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants