Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the neutron background simulation with GEANT #18596

Merged
merged 1 commit into from May 8, 2017

Conversation

calabria
Copy link
Contributor

@calabria calabria commented May 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

A new Pull Request was created by @calabria (Cesare Calabria) for master.

It involves the following packages:

SLHCUpgradeSimulations/Configuration
SimMuon/RPCDigitizer

@cmsbuild, @civanch, @mdhildreth, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @sviret, @jhgoh this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented May 6, 2017

are the RPC fixes not needed in 91X?

@civanch
Copy link
Contributor

civanch commented May 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19622/console Started: 2017/05/06 19:46

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18596/19622/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3378 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 62690
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1768214
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@civanch
Copy link
Contributor

civanch commented May 7, 2017

+1

@calabria
Copy link
Contributor Author

calabria commented May 7, 2017

@kpedro88 that fix is needed also in 91X but since there is a PR open for the RPC LinkBoard #18578 I expect @bapavlov can update it accordingly.

@kpedro88
Copy link
Contributor

kpedro88 commented May 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants