New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeding layer cache #186
Seeding layer cache #186
Conversation
…dditions to HitExtractorSTRP
Hi, I took CMSSW_7_0_X_2013-07-25-1400, pulled these changes and ran the unit tests and RelVals, all the tests passed. |
The following categories have been signed by speer (a.k.a. @thspeer on GitHub): Reconstruction @cms-git-reconstruction |
No Changes seen in tests |
@@ -221,7 +225,18 @@ void HitExtractorSTRP::cleanedOfClusters( const edm::Event& ev, HitExtractor::Hi | |||
edm::Handle<SiStripMatchedRecHit2DCollection> matchedHits; | |||
ev.getByLabel( theMatchedHits, matchedHits); | |||
if (skipClusters) cleanFrom=result.size(); | |||
range2SeedingHits( *matchedHits, result, accessor.stripTOBLayer(theIdLayer), sl, es); | |||
if (minAbsZ>0.) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why such a weird indentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm, I probably forgot to re-indent after un-commenting some parts. Thanks for spotting this, I will try to fix it when pushing a related development.
…CH16 use correct geometry in calcuating gemdphi in ME11
…-forSLHC14 Merge pull request cms-sw#186 from tahuang1991/CSC_Upgrade_Trigger_SLCH16
fix package name so that script can be run from command-line
Upstream updates from cms-sw#185
Trained parametric model for 2L
Update tau MVA classifier decisions and raw values to be stored for 2016 94X NanoAOD
…-sw#186) * add various electron track variables trk pt error, track momentum extrapolations * add variables for electron energy regression turned off by default in foresting configs seed crystal eta/phi/ieta/iphi in the endcaps are filled instead of being zero-ed (used for regression) also moved effective area, conversion veto variables outside of electron id block
Modified cmssw-ranking
a few changes related to seeding layers:
tracking results expected to be unchanged (functionalities to be used in the future by strip triplet seeding)