Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeding layer cache #186

Merged
merged 2 commits into from Aug 5, 2013
Merged

Seeding layer cache #186

merged 2 commits into from Aug 5, 2013

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Jul 25, 2013

a few changes related to seeding layers:

  • switch from cache based on DetLayers to cache based on SeedingLayers
  • fix small bug in HitExtractorSTRP
  • add possibility to set minAbsZ for TOB hits
  • add possibility to have multiple SeedingLayers per DetLayer

tracking results expected to be unchanged (functionalities to be used in the future by strip triplet seeding)

@nclopezo
Copy link
Contributor

Hi,

I took CMSSW_7_0_X_2013-07-25-1400, pulled these changes and ran the unit tests and RelVals, all the tests passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2013

The following categories have been signed by speer (a.k.a. @thspeer on GitHub): Reconstruction

@cms-git-reconstruction

@thspeer
Copy link
Contributor

thspeer commented Aug 2, 2013

No Changes seen in tests
Tested with CMSSW_7_0_X_2013-08-01-0200 (Test2)

@@ -221,7 +225,18 @@ void HitExtractorSTRP::cleanedOfClusters( const edm::Event& ev, HitExtractor::Hi
edm::Handle<SiStripMatchedRecHit2DCollection> matchedHits;
ev.getByLabel( theMatchedHits, matchedHits);
if (skipClusters) cleanFrom=result.size();
range2SeedingHits( *matchedHits, result, accessor.stripTOBLayer(theIdLayer), sl, es);
if (minAbsZ>0.) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why such a weird indentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm, I probably forgot to re-indent after un-commenting some parts. Thanks for spotting this, I will try to fix it when pushing a related development.

ktf added a commit that referenced this pull request Aug 5, 2013
@ktf ktf merged commit 9312043 into cms-sw:CMSSW_7_0_X Aug 5, 2013
tahuang1991 added a commit to tahuang1991/cmssw that referenced this pull request Sep 15, 2014
…CH16

use correct geometry in calcuating gemdphi in ME11
tahuang1991 pushed a commit to tahuang1991/cmssw that referenced this pull request Sep 15, 2014
…-forSLHC14

Merge pull request cms-sw#186 from tahuang1991/CSC_Upgrade_Trigger_SLCH16
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
fix package name so that script can be run from command-line
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
mariadalfonso added a commit to mariadalfonso/cmssw that referenced this pull request Dec 18, 2017
Trained parametric model for 2L
cmsbuild pushed a commit that referenced this pull request Aug 9, 2018
Update tau MVA classifier decisions and raw values to be stored for 2016 94X NanoAOD
fwyzard added a commit to fwyzard/cmssw that referenced this pull request Oct 6, 2018
bi-ran added a commit to bi-ran/cmssw that referenced this pull request Mar 12, 2019
…-sw#186)

* add various electron track variables

trk pt error, track momentum extrapolations

* add variables for electron energy regression

turned off by default in foresting configs

seed crystal eta/phi/ieta/iphi in the endcaps are filled instead of
being zero-ed (used for regression)

also moved effective area, conversion veto variables outside of electron
id block
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants