Add objects to allow possibility of storing energy deposit information in passive material

[bsunanda]

Useful to study energy weight factor in new calorimeters

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimDataFormats/CaloHit

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19625/console Started: 2017/05/07 12:24

[cmsbuild]

+1
Tested at: 22b8bb1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18601/19625/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18601/19625/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1681 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1831050
• DQMHistoTests: Total failures: 8633
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1822237
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

hi @bsunanda @civanch - did you consider if the string volume name could be represented instead as an int or something more data storage friendly?

[civanch]

@davidlange6, Volume name is not the best what can be proposed as an identificator of the passive material volume, because is run time & memory penalty. However, I do not see how to do this more efficiently. At least, this analysis should be done once and in normal production such hits should not be created.

[bsunanda]

@davidlange6 Could not find anything more suitable. This is only useful for very special cases (not standard production) and for evaluating weight factors in calorimeters

[davidlange6]

+1
ok, lets see the next step - one can easily think of a (long) int that allows a lookup table to a one-time-stored (or better even created from a geometry...) lookup table .