Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ME0 validation #18603

Merged
merged 2 commits into from May 16, 2017
Merged

Fix ME0 validation #18603

merged 2 commits into from May 16, 2017

Conversation

calabria
Copy link
Contributor

@calabria calabria commented May 7, 2017

Fix association to match the recent digitizer updates
@kpedro88

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2017

A new Pull Request was created by @calabria (Cesare Calabria) for CMSSW_9_1_X.

It involves the following packages:

Validation/MuonME0Validation

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@calabria
Copy link
Contributor Author

calabria commented May 9, 2017

Hi @kpedro88 , this is not high priority, but it is good to start the review and have it integrated. Thanks.

@kpedro88
Copy link
Contributor

kpedro88 commented May 9, 2017

please test
(I'm not actually responsible for validation/DQM...)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19680/console Started: 2017/05/09 16:25

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18603/19680/summary.html

Comparison Summary:

  • You potentially added 51 lines to the logs
  • Reco comparison results: 3367 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 48895
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1781975
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bf94cbc into cms-sw:CMSSW_9_1_X May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants