Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T offline DQM efficiency plots for the muons #18616

Merged
merged 4 commits into from May 10, 2017

Conversation

astakia
Copy link
Contributor

@astakia astakia commented May 8, 2017

Changes for the related code (PRs: #16233, #16234) to run centrally.
Based on the PR by @cbbrainerd and @z4027163 : #18085
This PR on the cms-sw:9_1_X : #18644

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

A new Pull Request was created by @astakia for master.

It involves the following packages:

DQMOffline/L1Trigger

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@kreczko, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19663/console Started: 2017/05/09 10:13

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18616/19663/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 23 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1820602
  • DQMHistoTests: Total failures: 17744
  • DQMHistoTests: Total nulls: 21
  • DQMHistoTests: Total successes: 1802657
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Pull request #18616 was updated. @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19675/console Started: 2017/05/09 15:35

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18616/19675/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1806 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1820534
  • DQMHistoTests: Total failures: 29621
  • DQMHistoTests: Total nulls: 449
  • DQMHistoTests: Total successes: 1790284
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@rekovic
Copy link
Contributor

rekovic commented May 10, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 061366b into cms-sw:master May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants