Pr92x L1T calo, muon, uGT for 2017 (v93.6 minus v93.3,v92.24) #18622

rekovic · 2017-05-08T15:27:44Z

92x PR meant to go into 9_1_0.
Total of 86 files, but big part of it are config files (37).

It includes updates for 2017 in Calo, Muon and uGT.

Calo calibrations 2017 caloStage2Params v1_v4 & v1_5. Letter set as default.
- Layer2 new EG/Tau Iso, Jet, MET. New feature MET PUS.
- Layer1 support for HEP17
- Needed LUT externals are in 2017 calo-calibrations EG/Tau/Jet/EtSums and Iso LUTs. cms-data/L1Trigger-L1TCalorimeter#17
Muon updates for 2017
- uGMT update of tracking of FW version (0x4010000) and (0x5000000).
- uGMT intermediate unpacker (relevant in DQM, not full emulator)
- uGMT unpacker fix problem of deleting all blocks in case of ZeroSupression
uGT
- Indexing and overlap-removal

It is equivalent to l1t-inegration-v93.6 minus two tags: v93.3 (omtf unpacker) and v92.24 (L1T Legacy Ntuple) which are both reverted.

Tag 93.3 needs to be blessed with efficiency plots.
Tag 92.24 need a fix to run on run1 and run2_2105.
So for now, they are both out.

… generator & LUT

Conflicts: L1Trigger/Configuration/python/customiseSettings.py

…hods in CaloParamsHelper needed to be propagated to L1TCaloParamsOnlineProd.

…JetAlgorithmFirmwareImp1.

… collection.

…a blocks and the BX cannot be reconstructed from them.

… muon candidate from the legacy information.

cmsbuild · 2017-05-15T20:42:21Z

+1
Tested at: 458bba8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18622/19834/summary.html

cmsbuild · 2017-05-15T20:42:28Z

Comparison job queued.

cmsbuild · 2017-05-15T23:09:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18622/19834/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3363 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1829394
DQMHistoTests: Total failures: 34688
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1794526
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

ggovi · 2017-05-16T08:35:56Z

CondFormats/L1TObjects/interface/L1GtDefinitions.h

@@ -136,7 +138,8 @@ enum L1GtConditionCategory {
    CondHfBitCounts,
    CondHfRingEtSums,
    CondBptx,
-    CondExternal
+    CondExternal,


@rekovic
Are these extended enums used in the persistent data? I mean, if the possible enum's values are stored in the DB, the previous releases won't be able to read the new data.

@rekovic @ggovi from AlCa side we are fine with this PR since this file is the only one in our domain.
We'll sign, once we have received a satisfactory answer to this question.

rekovic · 2017-05-16T12:58:26Z

@ggovi, @ghellwig Thanks.

Are these extended enums used in the persistent data? I mean, if the possible enum's values are stored in the DB, the previous releases won't be able to read the new data.

No. These enums are not stored in the DB.

ghellwig · 2017-05-16T13:30:12Z

+1
thanks @rekovic

rekovic · 2017-05-16T14:46:10Z

@ggovi, @ghellwig, can you also please sign the 91x version #18671 (same code, same branch) ?

ggovi · 2017-05-16T15:39:04Z

+1

cmsbuild · 2017-05-16T15:39:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

rekovic · 2017-05-16T16:08:42Z

@smuzaffar @davidlange6
Need cms-sw/cmsdist#3017 merged in 92x. It already is in 91x.

davidlange6 · 2017-05-16T16:31:33Z

+1

davidlange6 · 2017-05-17T14:07:13Z

hi @rekovic - looks like there is one workflow failing due to this - please provide a fix (its workflow 281)

Exception Message:
python encountered the error: <type 'exceptions.RuntimeError'>
edm::FileInPath unable to find file L1Trigger/L1TCalorimeter/data/lut_towEtThresh_dummy.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_2_X_2017-05-16-2300/src:/build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_2_X_2017-05-16-2300/external/slc6_amd64_gcc530/data:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-05-16-2300/src:/cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_9_2_X_2017-05-16-2300/external/slc6_amd64_gcc530/data
Current directory is: /build/cmsbld/jenkins-workarea/workspace/ib-run-relvals/CMSSW_9_2_X_2017-05-16-2300/pyRelval/281.0/281.0_EPOS_PPb_8160GeV_MinimumBias+EPOS_PPb_8160GeV_MinimumBias+DIGIUP15_PPb+RECOUP15_PPb+HARVESTUP15_PPb

----- End Fatal Exception -------------------------------------------------

rekovic · 2017-05-19T07:47:50Z

Hi @davidlange6

It is a LUT file that is still not used in any p-p workflows.
However the workflow with -era Run2_2016_pA picks it
up. Sorry I missed it in the last externals PR.
This is fixed with cms-sw/cmsdist#3054

thomreis and others added 30 commits May 2, 2017 09:12

Fix FatalRootError exception with GEN tree.

113f8bd

New cancel out windows. 'Aggressive' tuning of 3 April 2017.

0c1279e

Implement MET pileup subtraction with tower Et threshold LUT, add LUT…

92200ca

… generator & LUT

Changes to caloParams helper

843ca3b

Set correct uGMT and uGT FW version for RAW format change

0dd54c9

Document FW version numbers in GMT and GT unpackers.

6a1e193

Begin to add phi dependent layer1 LUTs

a6e70cd

add phi dependent support for layer1 calibrations

a8bf0ad

Conflicts: L1Trigger/Configuration/python/customiseSettings.py

updated calibration access

a68cca2

fix again

ba99ea8

add backwards support for previous calo params version

7713754

removing old

f0788a7

add new et binning to layer1 phi dependent

cb78e52

simplifying string concatenation

6350268

Add includes.

d856a0d

Set correct uGMT FW version for extrapolation LUT format changes

e9ee1bb

Fix compilation errors introduced in PR 498 (tag v92.14): changed met…

eefc432

…hods in CaloParamsHelper needed to be propagated to L1TCaloParamsOnlineProd.

Post rebase fix of customiseSettings of caloParams.

05aac25

Post rebase fix: add missed file caloStage2Params_2017_v1_4_cfi.py.

8078a41

Rebase fix to Stage2Layer2EtSumAlgorithmFirmwareImp1 and Stage2Layer2…

728031c

…JetAlgorithmFirmwareImp1.

Add L1TCalorimeter data.

9e0f8b3

Fix uGMT intermediate muon unpacker bug that fills muons in the wrong…

5feeab1

… collection.

Set default BX range in case the zero suppression deletes all the dat…

e7d7fc3

…a blocks and the BX cannot be reconstructed from them.

Corrected shape Id LUT

2a015cf

Added customisation to include legacy and upgrade in the same sequence

caf86e9

Adding token for the legacy muons

e1af8d4

Adding legacy muon to the ntuples

84c3cce

running configuration

3c88a3d

first running version with legacy muons appearing in the ntuples

771a6f2

fixing conversion. there was a missing charge_valid when creating the…

b24c37b

… muon candidate from the legacy information.

cmsbuild added l1-approved requires-external tests-started labels May 15, 2017

cmsbuild added tests-approved and removed tests-started labels May 15, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 15, 2017

ggovi reviewed May 16, 2017

View reviewed changes

cmsbuild added alca-approved and removed alca-pending labels May 16, 2017

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels May 16, 2017

cmsbuild added orp-approved and removed orp-pending labels May 16, 2017

cmsbuild merged commit 9f5fa5e into cms-sw:master May 16, 2017

rekovic mentioned this pull request May 19, 2017

TowEtThresh_dummy. cms-data/L1Trigger-L1TCalorimeter#18

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr92x L1T calo, muon, uGT for 2017 (v93.6 minus v93.3,v92.24) #18622

Pr92x L1T calo, muon, uGT for 2017 (v93.6 minus v93.3,v92.24) #18622

rekovic commented May 8, 2017 •

edited

cmsbuild commented May 15, 2017

cmsbuild commented May 15, 2017

cmsbuild commented May 15, 2017

ggovi May 16, 2017

ghellwig May 16, 2017

rekovic commented May 16, 2017

ghellwig commented May 16, 2017

rekovic commented May 16, 2017

ggovi commented May 16, 2017

cmsbuild commented May 16, 2017

rekovic commented May 16, 2017

davidlange6 commented May 16, 2017

davidlange6 commented May 17, 2017

rekovic commented May 19, 2017

Pr92x L1T calo, muon, uGT for 2017 (v93.6 minus v93.3,v92.24) #18622

Pr92x L1T calo, muon, uGT for 2017 (v93.6 minus v93.3,v92.24) #18622

Conversation

rekovic commented May 8, 2017 • edited

cmsbuild commented May 15, 2017

cmsbuild commented May 15, 2017

cmsbuild commented May 15, 2017

ggovi May 16, 2017

Choose a reason for hiding this comment

ghellwig May 16, 2017

Choose a reason for hiding this comment

rekovic commented May 16, 2017

ghellwig commented May 16, 2017

rekovic commented May 16, 2017

ggovi commented May 16, 2017

cmsbuild commented May 16, 2017

rekovic commented May 16, 2017

davidlange6 commented May 16, 2017

davidlange6 commented May 17, 2017

rekovic commented May 19, 2017

rekovic commented May 8, 2017 •

edited