Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC validation add hit timing and cleanup unused plots #18632

Merged
merged 5 commits into from May 10, 2017

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented May 9, 2017

This PR is to update the RPC digi validation and recHit validation:

  • Include RPC digi and recHit timing distributions for the phase-II upgrade simulation
  • Cleanup of unused monitor elements both in digi validation and rechit validation
    • "cluster size" plots in digi validation (suggested to be removed by Roumyana)
    • "unmatched" rechits in rechit validation (raises false alarms, concluded to be removed during the RPC-DPG meeting)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

A new Pull Request was created by @jhgoh (Junghwan John Goh) for master.

It involves the following packages:

Validation/MuonRPCDigis
Validation/RPCRecHits

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19688/console Started: 2017/05/09 18:22

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18632/19688/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1692 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833883
  • DQMHistoTests: Total failures: 27340
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1806363
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4710a08 into cms-sw:master May 10, 2017
@jhgoh jhgoh deleted the iRPCValidation branch May 16, 2017 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants